Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose Internal IP Address #13

Open
janeczku opened this issue May 9, 2018 · 2 comments
Open

Expose Internal IP Address #13

janeczku opened this issue May 9, 2018 · 2 comments

Comments

@janeczku
Copy link
Contributor

janeczku commented May 9, 2018

Some implementations need to know the internal IP address of the VM. Please add a Driver property of PrivateIPAddress.
@x1022as
Copy link
Contributor

x1022as commented May 15, 2018

will take a look at this.

feel free to commit a pr if you are willing to.

@x1022as
Copy link
Contributor

x1022as commented Jun 2, 2018

seems it won't work without modifying docker-machine.

private-address is allocated, and can not be fetched before instance created.

docker machine save driver struct to disk with its initial info, private ip address is not allocated yet.

@hvpareja hvpareja mentioned this issue Mar 29, 2019
Merged
zzhaoy added a commit that referenced this issue Aug 27, 2019
@zzhaoy
Merge pull request #22 from hvpareja/hector/make-elastic-ip-optional
7cdb19a 
Make ElasticIP optional and expose PrivateIP when not allocated (#12 and #13)
@AdamVB AdamVB mentioned this issue Oct 31, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@x1022as @janeczku