Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Driver does not populate IPAddress field in BaseDriver struct #12

Open
janeczku opened this issue May 9, 2018 · 1 comment
Open

Driver does not populate IPAddress field in BaseDriver struct #12

janeczku opened this issue May 9, 2018 · 1 comment

Comments

@janeczku
Copy link
Contributor

janeczku commented May 9, 2018

Elastic IP Address should be populated in the IPAddress field of the Driver struct. See https://github.com/docker/machine/blob/d889abc3528b09753746caaa79bb943bc835c20f/libmachine/drivers/base.go#L17.
@x1022as
Copy link
Contributor

x1022as commented May 15, 2018

make sense to me.

but Driver struct gets both ElasticIPId and ElasticIP fields in it. these two fields seem related, it will be much more clear to put them together.

Any particular reason to use IPAddress?

@hvpareja hvpareja mentioned this issue Mar 29, 2019
Merged
zzhaoy added a commit that referenced this issue Aug 27, 2019
@zzhaoy
Merge pull request #22 from hvpareja/hector/make-elastic-ip-optional
7cdb19a 
Make ElasticIP optional and expose PrivateIP when not allocated (#12 and #13)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@x1022as @janeczku