Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using ',' as decimal separator readings are corrupted #423

Open
chwalters opened this issue Jul 19, 2018 · 0 comments
Open

When using ',' as decimal separator readings are corrupted #423

chwalters opened this issue Jul 19, 2018 · 0 comments
Assignees

Comments

@chwalters
Copy link
Contributor

When using phone locale such that ',' (comma) is the decimal separator (such as Nederland/Dutch), the app won't allow users to enter valid data, e.g., 12.8 becomes 128 when saved, but 12,8 isn't accepted as a valid input. Reported by http://community.glucosio.org/t/cant-use-decimals-for-mmol-l-level/164/4 I was able to duplicate in Android simulator

Steps to Reproduce

Go to 'Settings->System->Languages & Input->Languages and change phone to 'Nederlands' locale. Try adding a reading into Glucosio. Readings cannot be edited correctly once the locale is changed either.

chwalters pushed a commit that referenced this issue Jul 19, 2018
@emartynov emartynov assigned emartynov and chwalters and unassigned emartynov Jul 21, 2018
emartynov pushed a commit that referenced this issue Jul 28, 2018
* Disable 'Backup to Google Drive' function as a hot fix for #416

* Use number formatter to honor locale settings for entry and display, proposed fix for #423

* Increase decimal places shown during mgDl to mmol display, part of overall fix for #423
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants