Pin numpy<2 in ci_tests_legacy.yaml #3641
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
The
ci_test_legacy.yaml
GitHub workflow has been failing since last month with a TypeError, e.g. at https://github.com/GenericMappingTools/pygmt/actions/runs/11450983970/job/31859442362#step:6:1474:The solution upstream at shapely shapely/shapely#2098 is to upgrade to shapely 2.0.6 to deal with the incompatibilty with numpy 2.1. But I think we should just test on
numpy<2
since the legacy tests are meant to test old versions.Also, I've cherry-picked commit 1263075 from #3639 here so that the terminal outputs for the legacy tests are colored (as per #3330).
Fixes #
Preview:
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash command is:
/format
: automatically format and lint the code