Unit tests fail; expected values are from Litecoin

[HoorayJorge]

What version of garlicoin-core are you using?

(04efd05)

Machine specs:

  Model Name:	  MacBook Air
  Model Identifier:	MacBookAir10,1
  Chip:	Apple M1
  Total Number of Cores:	8 (4 performance and 4 efficiency)
  Memory:	16 GB
  System Firmware Version:	7459.141.1
  OS Loader Version:	7459.141.1

  System Version:	macOS 12.5.1 (21G83)
  Kernel Version:	Darwin 21.6.0
  Boot Volume:	Macintosh HD
  Boot Mode:	Normal
  Secure Virtual Memory:	Enabled
  System Integrity Protection:	Enabled
  Time since boot:	4 days 7:28

Any extra information that might be useful in the debugging process.

jorge@batcave Garlicoin % make -j "$(($(sysctl -n hw.physicalcpu)+1))" check
Making check in src
/Applications/Xcode.app/Contents/Developer/usr/bin/make  check-TESTS check-local
Running test/util/bitcoin-util-test.py...
/opt/homebrew/bin/python3 ../test/util/bitcoin-util-test.py
/Users/jorge/clean_git/Garlicoin/src/../test/util/bitcoin-util-test.py:31: DeprecationWarning: This method will be removed in Python 3.12. Use 'parser.read_file()' instead.
  config.readfp(open(os.path.join(os.path.dirname(__file__), "../config.ini")))
2022-09-04 22:28:18,370 - ERROR - Output data mismatch for tt-delin1-out.json (format json)
2022-09-04 22:28:18,370 - ERROR - Output formatting mismatch for tt-delin1-out.json:
*** tt-delin1-out.json
--- returned
***************
*** 197,203 ****
                  "reqSigs": 1,
                  "type": "pubkeyhash",
                  "addresses": [
!                     "LYLPXtUPKrXH3JFW5ZV1o4kEzBBdkaYVpD"
                  ]
              }
          },
--- 197,203 ----
                  "reqSigs": 1,
                  "type": "pubkeyhash",
                  "addresses": [
!                     "GWxMgoVWE3tWrxrdqN9pwp2Nh8cCej5G54"
                  ]
              }
          },
***************
*** 210,216 ****
                  "reqSigs": 1,
                  "type": "pubkeyhash",
                  "addresses": [
!                     "LV7U1r5VrCzJ7GhFoBJrFmNEoTBRUqZvNB"
                  ]
              }
          }
--- 210,216 ----
                  "reqSigs": 1,
                  "type": "pubkeyhash",
                  "addresses": [
!                     "GTjSAm6ckQMXvwJPYyyfQWeNWQbzM2xVWw"
                  ]
              }
          }

2022-09-04 22:28:18,384 - ERROR - Output data mismatch for tt-delout1-out.json (format json)
2022-09-04 22:28:18,384 - ERROR - Output formatting mismatch for tt-delout1-out.json:
*** tt-delout1-out.json
--- returned
***************
*** 206,212 ****
                  "reqSigs": 1,
                  "type": "pubkeyhash",
                  "addresses": [
!                     "LYLPXtUPKrXH3JFW5ZV1o4kEzBBdkaYVpD"
                  ]
              }
          }
--- 206,212 ----
                  "reqSigs": 1,
                  "type": "pubkeyhash",
                  "addresses": [
!                     "GWxMgoVWE3tWrxrdqN9pwp2Nh8cCej5G54"
                  ]
              }
          }

2022-09-04 22:28:18,398 - ERROR - Output data mismatch for tt-locktime317000-out.json (format json)
2022-09-04 22:28:18,398 - ERROR - Output formatting mismatch for tt-locktime317000-out.json:
*** tt-locktime317000-out.json
--- returned
***************
*** 206,212 ****
                  "reqSigs": 1,
                  "type": "pubkeyhash",
                  "addresses": [
!                     "LYLPXtUPKrXH3JFW5ZV1o4kEzBBdkaYVpD"
                  ]
              }
          },
--- 206,212 ----
                  "reqSigs": 1,
                  "type": "pubkeyhash",
                  "addresses": [
!                     "GWxMgoVWE3tWrxrdqN9pwp2Nh8cCej5G54"
                  ]
              }
          },
***************
*** 219,225 ****
                  "reqSigs": 1,
                  "type": "pubkeyhash",
                  "addresses": [
!                     "LV7U1r5VrCzJ7GhFoBJrFmNEoTBRUqZvNB"
                  ]
              }
          }
--- 219,225 ----
                  "reqSigs": 1,
                  "type": "pubkeyhash",
                  "addresses": [
!                     "GTjSAm6ckQMXvwJPYyyfQWeNWQbzM2xVWw"
                  ]
              }
          }

2022-09-04 22:28:18,432 - ERROR - Output data mismatch for txcreate1.hex (format hex)
2022-09-04 22:28:18,433 - ERROR - Output formatting mismatch for txcreate1.hex:
*** txcreate1.hex
--- returned
***************
*** 1 ****
- 02000000031e1977dc524bec5929e95d8d0946812944b7b5bda12f5b99fdf557773f2ee65e0100000000ffffffff8a398e44546dce0245452b90130e86832b21fd68f26662bc33aeb7c6c115d23c1900000000ffffffffb807ab93a7fcdff7af6d24581a4a18aa7c1db1ebecba2617a6805b009513940f0c00000000ffffffff020001a04a000000001976a9145688ac6b45bcc02f738e2970d2381d068d68eea788ac27440f00000000001976a9141c2578aa5e5c10ba3b6c3b71a78bff48077d8ba188ac00000000
--- 0 ----

2022-09-04 22:28:18,437 - ERROR - Error parsing command output as json: Expecting value: line 1 column 1 (char 0)
2022-09-04 22:28:18,482 - ERROR - Output data mismatch for txcreatescript3.json (format json)
2022-09-04 22:28:18,483 - ERROR - Output formatting mismatch for txcreatescript3.json:
*** txcreatescript3.json
--- returned
***************
*** 17,23 ****
                  "reqSigs": 1,
                  "type": "witness_v0_scripthash",
                  "addresses": [
!                     "ltc1qp0lfxhnscvsu0j36l36uurgv5tuck4pzuqytkvwqp3kh78cupttq8dslwf"
                  ]
              }
          }
--- 17,23 ----
                  "reqSigs": 1,
                  "type": "witness_v0_scripthash",
                  "addresses": [
!                     "grlc1qp0lfxhnscvsu0j36l36uurgv5tuck4pzuqytkvwqp3kh78cupttqdfzvyp"
                  ]
              }
          }

2022-09-04 22:28:18,501 - ERROR - Output data mismatch for txcreatesignv1.hex (format hex)
2022-09-04 22:28:18,501 - ERROR - Output formatting mismatch for txcreatesignv1.hex:
*** txcreatesignv1.hex
--- returned
***************
*** 1 ****
- 0100000001f77bd0a57e5b5e041e95567e0f01c3789af7f624ff490f756fb408362489276c0000000000ffffffff01a0860100000000001976a914834584e0afbd77db57fcf4a3a076b8d3e02aa6fb88ac00000000
--- 0 ----

2022-09-04 22:28:18,512 - ERROR - Error parsing command output as json: Expecting value: line 1 column 1 (char 0)
2022-09-04 22:28:18,522 - ERROR - Output data mismatch for txcreatesignv2.hex (format hex)
2022-09-04 22:28:18,523 - ERROR - Output formatting mismatch for txcreatesignv2.hex:
*** txcreatesignv2.hex
--- returned
***************
*** 1 ****
- 0200000001f77bd0a57e5b5e041e95567e0f01c3789af7f624ff490f756fb408362489276c0000000000ffffffff01a0860100000000001976a914834584e0afbd77db57fcf4a3a076b8d3e02aa6fb88ac00000000
--- 0 ----

2022-09-04 22:28:18,543 - ERROR - Output data mismatch for txcreateoutpubkey1.json (format json)
2022-09-04 22:28:18,543 - ERROR - Output formatting mismatch for txcreateoutpubkey1.json:
*** txcreateoutpubkey1.json
--- returned
***************
*** 17,23 ****
                  "reqSigs": 1,
                  "type": "pubkey",
                  "addresses": [
!                     "La2DHFRvKvGwR78JkkMCzEw6BJUrSQa72A"
                  ]
              }
          }
--- 17,23 ----
                  "reqSigs": 1,
                  "type": "pubkey",
                  "addresses": [
!                     "GYeBSAT3E7eBEmjSWZ228zDDtFuRGUN6Dd"
                  ]
              }
          }

2022-09-04 22:28:18,564 - ERROR - Output data mismatch for txcreateoutpubkey2.json (format json)
2022-09-04 22:28:18,564 - ERROR - Output formatting mismatch for txcreateoutpubkey2.json:
*** txcreateoutpubkey2.json
--- returned
***************
*** 17,23 ****
                  "reqSigs": 1,
                  "type": "witness_v0_keyhash",
                  "addresses": [
!                     "ltc1q5fgkuac9s2ry56jka5s6zqsyfcugcchrqgz2yl"
                  ]
              }
          }
--- 17,23 ----
                  "reqSigs": 1,
                  "type": "witness_v0_keyhash",
                  "addresses": [
!                     "grlc1q5fgkuac9s2ry56jka5s6zqsyfcugcchrlzuyxz"
                  ]
              }
          }

2022-09-04 22:28:18,610 - ERROR - Output data mismatch for txcreatedata1.hex (format hex)
2022-09-04 22:28:18,610 - ERROR - Output formatting mismatch for txcreatedata1.hex:
*** txcreatedata1.hex
--- returned
***************
*** 1 ****
- 0200000001efc59c584fb0be1066baf08b93f8baf0d9b9beaafcdd318a59cda6302dc1e9690000000000ffffffff02400d0300000000001976a914feda50542e61108cf53b93dbffa0959f91ccb32588ac0084d71700000000526a4c4f54686973204f505f52455455524e207472616e73616374696f6e206f7574707574207761732063726561746564206279206d6f646966696564206372656174657261777472616e73616374696f6e2e00000000
--- 0 ----

2022-09-04 22:28:18,614 - ERROR - Error parsing command output as json: Expecting value: line 1 column 1 (char 0)
2022-09-04 22:28:18,619 - ERROR - Output data mismatch for txcreatedata2.hex (format hex)
2022-09-04 22:28:18,619 - ERROR - Output formatting mismatch for txcreatedata2.hex:
*** txcreatedata2.hex
--- returned
***************
*** 1 ****
- 0200000001efc59c584fb0be1066baf08b93f8baf0d9b9beaafcdd318a59cda6302dc1e9690000000000ffffffff02400d0300000000001976a914feda50542e61108cf53b93dbffa0959f91ccb32588ac0000000000000000526a4c4f54686973204f505f52455455524e207472616e73616374696f6e206f7574707574207761732063726561746564206279206d6f646966696564206372656174657261777472616e73616374696f6e2e00000000
--- 0 ----

2022-09-04 22:28:18,623 - ERROR - Error parsing command output as json: Expecting value: line 1 column 1 (char 0)
2022-09-04 22:28:18,628 - ERROR - Output data mismatch for txcreatedata_seq0.hex (format hex)
2022-09-04 22:28:18,628 - ERROR - Output formatting mismatch for txcreatedata_seq0.hex:
*** txcreatedata_seq0.hex
--- returned
***************
*** 1 ****
- 0200000001efc59c584fb0be1066baf08b93f8baf0d9b9beaafcdd318a59cda6302dc1e9690000000000fdffffff01400d0300000000001976a914feda50542e61108cf53b93dbffa0959f91ccb32588ac00000000
--- 0 ----

2022-09-04 22:28:18,632 - ERROR - Error parsing command output as json: Expecting value: line 1 column 1 (char 0)
2022-09-04 22:28:18,641 - ERROR - Output data mismatch for txcreatedata_seq1.json (format json)
2022-09-04 22:28:18,641 - ERROR - Output formatting mismatch for txcreatedata_seq1.json:
*** txcreatedata_seq1.json
--- returned
***************
*** 35,41 ****
                  "reqSigs": 1,
                  "type": "pubkeyhash",
                  "addresses": [
!                     "LN7rZWXF75vE7aNq6EHjtThcro5GpGmjYy"
                  ]
              }
          }
--- 35,41 ----
                  "reqSigs": 1,
                  "type": "pubkeyhash",
                  "addresses": [
!                     "GLjpiRYN1HHTwEyxr2xZ3CykZkVqjAT3fe"
                  ]
              }
          }

2022-09-04 22:28:18,661 - ERROR - Output data mismatch for txcreatemultisig1.json (format json)
2022-09-04 22:28:18,661 - ERROR - Output formatting mismatch for txcreatemultisig1.json:
*** txcreatemultisig1.json
--- returned
***************
*** 17,25 ****
                  "reqSigs": 2,
                  "type": "multisig",
                  "addresses": [
!                     "La2DHFRvKvGwR78JkkMCzEw6BJUrSQa72A",
!                     "LZkrFMdJCxcpf2fSorE4MJHUNZGfAnD7gf",
!                     "LNZrr8v1gBobYuA3ABbTkRnuf7n5RRo5Cz"
                  ]
              }
          }
--- 17,25 ----
                  "reqSigs": 2,
                  "type": "multisig",
                  "addresses": [
!                     "GYeBSAT3E7eBEmjSWZ228zDDtFuRGUN6Dd",
!                     "GYNpQGeR79z4UhGaZetsW3Zc5WhE7g1uwB",
!                     "GMBq13w8aPAqNZmAuzGGuB53N5CeM5MHdP"
                  ]
              }
          }

2022-09-04 22:28:18,702 - ERROR - Output data mismatch for txcreatemultisig3.json (format json)
2022-09-04 22:28:18,702 - ERROR - Output formatting mismatch for txcreatemultisig3.json:
*** txcreatemultisig3.json
--- returned
***************
*** 17,23 ****
                  "reqSigs": 1,
                  "type": "witness_v0_scripthash",
                  "addresses": [
!                     "ltc1qu9dgdg330r6r84g5mw7wqshg04exv2uttmw2elfwx74h5tgntuzsk3x5nd"
                  ]
              }
          }
--- 17,23 ----
                  "reqSigs": 1,
                  "type": "witness_v0_scripthash",
                  "addresses": [
!                     "grlc1qu9dgdg330r6r84g5mw7wqshg04exv2uttmw2elfwx74h5tgntuzsu458e9"
                  ]
              }
          }

2022-09-04 22:28:18,743 - ERROR - FAILED_TESTCASES:
['Deletes a single input from a transaction (output in json)',
 'Deletes a single output from a transaction (output in json)',
 'Adds an nlocktime to a transaction (output in json)',
 'Creates a new transaction with three inputs and two outputs',
 'Creates a new transaction with three inputs and two outputs (output in json)',
 'Create a new transaction with a single output script (OP_DROP) in a P2WSH (output as json)',
 'Creates a new v1 transaction with a single input and a single output, and then signs the transaction',
 'Creates a new v1 transaction with a single input and a single output, and then signs the transaction (output in json)',
 'Creates a new transaction with a single input and a single output, and then signs the transaction',
 'Creates a new transaction with a single pay-to-pubkey output (output as json)',
 'Creates a new transaction with a single pay-to-witness-pubkey output (output as json)',
 'Creates a new transaction with one input, one address output and one data output',
 'Creates a new v1 transaction with one input, one address output and one data output (output in json)',
 'Creates a new transaction with one input, one address output and one data (zero value) output',
 'Creates a new transaction with one input, one address output and one data (zero value) output (output in json)',
 'Creates a new transaction with one input with sequence number and one address output',
 'Creates a new transaction with one input with sequence number and one address output (output in json)',
 'Adds a new input with sequence number to a transaction (output in json)',
 'Creates a new transaction with a single 2-of-3 multisig output (output in json)',
 'Creates a new transaction with a single 2-of-3 multisig in a P2WSH output (output in json)']
make[3]: *** [check-local] Error 1
make[3]: *** Waiting for unfinished jobs....
../build-aux/test-driver: line 112: 23020 Abort trap: 6           "$@" >> "$log_file" 2>&1
FAIL: qt/test/test_garlicoin-qt
FAIL: test/test_garlicoin
============================================================================
Testsuite summary for Garlicoin Core 0.18.0
============================================================================
# TOTAL: 2
# PASS:  0
# SKIP:  0
# XFAIL: 0
# FAIL:  2
# XPASS: 0
# ERROR: 0
============================================================================
See src/test-suite.log
Please report to https://github.com/GarlicoinOrg/Garlicoin/issues
============================================================================
make[4]: *** [test-suite.log] Error 1
make[3]: *** [check-TESTS] Error 2
make[2]: *** [check-am] Error 2
make[1]: *** [check-recursive] Error 1
make: *** [check-recursive] Error 1

[HoorayJorge]

The functional tests have the same issue with Litecoin values, as well as formatting issues. gen_base58_test_vectors.py needs to be updated to generate the correct values.