Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ipv6 and address without port #237

Open
nimeng1299 opened this issue Aug 5, 2024 · 1 comment
Open

Support ipv6 and address without port #237

nimeng1299 opened this issue Aug 5, 2024 · 1 comment
Labels
good first issue Good for newcomers lang: ALL Affects all versions of minestat new feature Request something new

Comments

@nimeng1299
Copy link

Feature Description

in CSharp
If query ipv6 server

MineStat ms = new MineStat("2ff8:82c6:3572:1473:1778:1234:ffc7:dfd7", 25565);

ms.ServerUp is false

and MineStat need a address and port,but sometimes the server hides the port, like aa.top

@nimeng1299 nimeng1299 added the new feature Request something new label Aug 5, 2024
@mindsolve mindsolve added good first issue Good for newcomers lang: ALL Affects all versions of minestat labels Aug 6, 2024
@mindsolve
Copy link
Collaborator

Hi @nimeng1299 and welcome to MineStat!

You are correct that some of the MineStat variants do not support IPv6 at the moment. Thank you for the feature request.

To the second part of your question: There are two ways to "hide" the server port. Either its just the default port (25565), or its based on SRV DNS records. We do not have SRV support in C# at the moment, as that would require external dependencies, which we are trying to avoid, if possible. See #142 for future progress.

I've created issue #238 to make the port in C# optional, as in other language editions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers lang: ALL Affects all versions of minestat new feature Request something new
Projects
None yet
Development

No branches or pull requests

2 participants