Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feed/Offer-Request Card - View More #149

Open
Mohammedks713 opened this issue May 21, 2020 · 6 comments · May be fixed by #161
Open

Feed/Offer-Request Card - View More #149

Mohammedks713 opened this issue May 21, 2020 · 6 comments · May be fixed by #161
Assignees
Labels
2 - medium Level of effort is Medium

Comments

@Mohammedks713
Copy link
Collaborator

NOTE: this refers to the View Button which will appear on the card when the text is cut off. It does not refer to the other elements of the card such as the share, like, or comment buttons.

As a user
Given I am on the card
When I click on the View More button,
Then I will be shown more of the text on the card

image

@Mohammedks713 Mohammedks713 added this to the Feed/Offer-Request Card milestone May 21, 2020
@ethanswift
Copy link
Contributor

ethanswift commented May 23, 2020

@devarshjoshi , @Mohammedks713 the content and header of the card feed don't have issues, its missing.

@ethanswift ethanswift self-assigned this May 24, 2020
@OnyekachiSamuel OnyekachiSamuel added the 2 - medium Level of effort is Medium label May 24, 2020
@devarshjoshi
Copy link
Collaborator

@ethanswift do you need a separate ticket for this? I can add details to this ticket itself.

@ethanswift
Copy link
Contributor

The point is, the card title and card body text don't have issues. In this specific case, the position of the button will get defined based on the body of the text.
I'm already working on the title and body and will pass on with this issue, if you make a separate issue, I'll attach that them. @devarshjoshi

@ethanswift ethanswift linked a pull request May 26, 2020 that will close this issue
4 tasks
@devarshjoshi
Copy link
Collaborator

@ethanswift 6 lines max for the card.

@devarshjoshi
Copy link
Collaborator

@ethanswift any updates here?

@ethanswift
Copy link
Contributor

@ethanswift any updates here?

My PR is under review, Luko is also working on an issue which covers this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - medium Level of effort is Medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants