Added last_login on the list_users method #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: cork/cork.py
|
Updated the test cases to pass |
|
Hi @FedericoCeratto could you please have a look at merging this pull request? |
|
Hi @Jacksonville, adding last_login to list_users would change the API and also require every other backend to implement last_login. What would you think of having last_login as an optional feature? |
|
No problem @FedericoCeratto, sounds like a plan. |
|
@Jacksonville I don't, but it could be added with a global flag to enable it. When enabled on a backend that supports it, it would be updated on every login and maybe returned by a last_login() property. |
FedericoCeratto
force-pushed
the
master
branch
3 times, most recently
from
665c993
to
ebb2777
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was interested in this information for my user admin screen