Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ICAT #232

Merged
merged 31 commits into from
Mar 17, 2024
Merged

Implement ICAT #232

merged 31 commits into from
Mar 17, 2024

Conversation

dunep
Copy link
Contributor

@dunep dunep commented Mar 13, 2024

No description provided.

@ACat701
Copy link
Contributor

ACat701 commented Mar 15, 2024

We wanted both positional and velocity control on the climber. We also wanted them both to be Motion Magic. I'm not sure how we'll make sure that the PID works in both cases. Maybe it'll just work like magic? Maybe its not actually a problem and I'm just really tired?

@ACat701
Copy link
Contributor

ACat701 commented Mar 15, 2024

@TaylerUva ^^

@ACat701
Copy link
Contributor

ACat701 commented Mar 15, 2024

Also im trying to think about how we should account for other commands interrupting the PrepAmp command. As i have it written right now, everything kinda explodes if it fails to transfer the amp note into the amper and that would run until its interrupted and them maybe things will explode and idk I'm very tired

@ACat701 ACat701 changed the title Implement new climber Implement ICAT Mar 15, 2024
@TaylerUva
Copy link
Member

We wanted both positional and velocity control on the climber. We also wanted them both to be Motion Magic. I'm not sure how we'll make sure that the PID works in both cases. Maybe it'll just work like magic? Maybe its not actually a problem and I'm just really tired?

You would have 2 PIDs but we don't need velocity in climber just voltage

@ACat701
Copy link
Contributor

ACat701 commented Mar 16, 2024

TESTING NOTES

  • CAN ids
  • Set value of Intake ABS_ENCODER_OFFSET and Intake ABS_ENCODER_INVERT
  • Determine if we will need to add an ABS_ENCODER_ROLLOVER
  • Probably comment out stowing the pivot for now
  • Set software limits

@TaylerUva TaylerUva linked an issue Mar 16, 2024 that may be closed by this pull request
@TaylerUva
Copy link
Member

DISABLE CURRENT LIMITING ON downwards only

@TaylerUva
Copy link
Member

Climber up waits for amp

@ACat701 ACat701 marked this pull request as ready for review March 16, 2024 20:49
@ACat701 ACat701 requested a review from a team as a code owner March 16, 2024 20:50
src/main/java/frc/robot/Robot.java Show resolved Hide resolved
src/main/java/frc/robot/Robot.java Show resolved Hide resolved
src/main/java/frc/robot/RobotContainer.java Show resolved Hide resolved
src/main/java/frc/robot/RobotContainer.java Show resolved Hide resolved
@TaylerUva TaylerUva enabled auto-merge (squash) March 17, 2024 06:13
@TaylerUva TaylerUva merged commit 02cead4 into main Mar 17, 2024
1 check passed
@TaylerUva TaylerUva deleted the implement-new-climber- branch March 17, 2024 06:16
@ACat701 ACat701 restored the implement-new-climber- branch March 17, 2024 06:20
@ACat701 ACat701 deleted the implement-new-climber- branch March 17, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rework Intake Pivot/Climber from ground up
3 participants