-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have MDK specify alternate Behat browsers #163
Comments
I agree, I've ran into that as well. |
Would be particularly nice if this could allow us to avoid selenium completely & use ChromeDriver (ideally by default). |
I'm working on improving his in Moodle more generally to improve support. When I get that over the line (i.e. when I have some time) I also intend to consider shipping some defaults, and to consider how these fit into MDK. |
Oh, hi :) That was quick! |
Yup - take a look at MDL-66979 instead. I'm trying to migrate to W3C WebDriver so we can ditch the JsonWire webdriver we currently use. That opens things up massively for other browsers (Edge, Firefox, Safari). |
A quick look at that looks like you've got the basics working and now going through all the tests to fix up anything that needs updating to make sure they still pass? |
In fact it looks like you're nearly done - is there any particular area that it would be helpful to try out/look at/beat into submission? |
It would be handy if we could more easily allow for selection of a different browser.
In terms of config, we just need something like:
And then to run, we need to specify an additional argument when running behat:
The existing behat addConfig commands in MDK only deal with a line at a time.
I'd like to suggest we perhaps add a line to
require_once
another config file (stored within MDK somewhere) to help with this.The text was updated successfully, but these errors were encountered: