Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Restore search functionality #319

Merged
merged 2 commits into from
May 11, 2024
Merged

🐛 Restore search functionality #319

merged 2 commits into from
May 11, 2024

Conversation

shnizzedy
Copy link
Member

Fixes

Resolves #313 by @shnizzedy
Resolves "the search feature isn't working in the cpac docs" by @e-kenneally

Description

When we updated the theme, some JS that was included in the old theme templates wasn't injected into the new theme. This PR restores those scripts.

Technical details

Two of the same errors are still appearing in the console, one of which I think is from the script raising it double-loading, but search works with just the one error resolved.

Screenshots

Before

https://fcp-indi.github.io/docs/nightly/search?q=Jon&check_keywords=yes&area=default#
console errors

After

https://fcp-indi.github.io/docs/nightly/search?q=Jon&check_keywords=yes&area=default#
onsole errors

Checklist

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@shnizzedy shnizzedy added this to the v1.8.7 milestone May 4, 2024
@shnizzedy shnizzedy requested a review from a team May 10, 2024 01:00
@shnizzedy shnizzedy added the bug label May 10, 2024
@shnizzedy shnizzedy merged commit 74ad49a into source May 11, 2024
@shnizzedy shnizzedy deleted the fix-search branch May 11, 2024 02:47
anibalsolon pushed a commit that referenced this pull request May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

🐛 Search stopped working in C-PAC docs
2 participants