Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Glasser Template Output Incomplete #23

Open
14 tasks
nimzodisaster opened this issue Feb 8, 2024 · 3 comments
Open
14 tasks

🐛 Glasser Template Output Incomplete #23

nimzodisaster opened this issue Feb 8, 2024 · 3 comments
Labels
bug Something isn't working RBC https://github.com/PennLINC/RBC user-reported

Comments

@nimzodisaster
Copy link

Describe the bug

Output for Glasser Atlas contains time-series for 180 ROIs but atlas has 360.

To reproduce

No response

Preconfig

  • default
  • abcd-options
  • anat-only
  • blank
  • ccs-options
  • fmriprep-options
  • fx-options
  • monkey
  • monkey-ABCD
  • ndmg
  • nhp-macaque
  • preproc
  • rbc-options
  • rodent

Custom pipeline configuration

No response

Run command

No response

Expected behavior

360 ROI timeseries for Glasser Atlas, not 180

Acceptance criteria

360 ROI timeseries for Glasser Atlas, not 180

Screenshots

No response

C-PAC version

Version 1.8.4.dev

Container platform

No response

Docker and/or Singularity version(s)

No response

Additional context

No response

@nimzodisaster nimzodisaster added the bug Something isn't working label Feb 8, 2024
@sgiavasis
Copy link
Contributor

Hi @nimzodisaster,

Thanks for the bug report. We are releasing v1.8.7 this week and have begun development for v1.8.8, where we will be focusing heavily on stability and robustness, and we will look into this issue.

@kjamison
Copy link

I just encountered this problem as well, and can confirm that the output should have 360 regions. This is probably related to the fact that some of the files distributed with the Glasser atlas have both left and right hemisphere labeled 1-180, but it should be 1-180 for right hemisphere, and 181-360 for left hemisphere.

@shnizzedy
Copy link
Member

This issue is probably related to / a duplicate of neurodata/neuroparc#32, or at least will be resolved when we replace our Neuroparc copy of Glasser to get around that issue.

@shnizzedy shnizzedy changed the title 🐛 [User-reported Bug] Glasser Template Output Incomplete 🐛 Glasser Template Output Incomplete Jun 24, 2024
@shnizzedy shnizzedy transferred this issue from FCP-INDI/C-PAC Jun 24, 2024
@shnizzedy shnizzedy added the RBC https://github.com/PennLINC/RBC label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working RBC https://github.com/PennLINC/RBC user-reported
Projects
Status: 🔖 Ready/Next
Development

No branches or pull requests

4 participants