-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weâll occasionally send you account related emails.
Already on GitHub? Sign in to your account
đ home page / tabs / order of processing / nuisance regression / how to fork #131
Comments
There's a flowchart in the user documentation here that shows the sequence of steps that C-PAC follows: |
After functional preprocessing is complete by default |
Also after functional preprocessing (and anatomical to template registration and functional to template warp) is complete, and in parallel to each other |
There is some (although not much beyond ) documentation at https://fcp-indi.github.io/docs/user/longitudinal and some in the comments included in the default pipeline YAML: longitudinal_template_generation:
# If you have multiple T1w's, you can generate your own run-specific custom
# T1w template to serve as an intermediate to the standard template for
# anatomical registration.
# This runs before the main pipeline as it requires multiple T1w sessions
# at once.
run: Off
# Freesurfer longitudinal template algorithm using FSL FLIRT
# Method to average the dataset at each iteration of the template creation
# Options: median, mean or std
average_method: median
# Degree of freedom for FLIRT in the template creation
# Options: 12 (affine), 9 (traditional), 7 (global rescale) or 6 (rigid body)
dof: 12
# Interpolation parameter for FLIRT in the template creation
# Options: trilinear, nearestneighbour, sinc or spline
interp: trilinear
# Cost function for FLIRT in the template creation
# Options: corratio, mutualinfo, normmi, normcorr, leastsq, labeldiff or bbr
cost: corratio
# Number of threads used for one run of the template generation algorithm
thread_pool: 2
# Threshold of transformation distance to consider that the loop converged
# (-1 means numpy.finfo(np.float64).eps and is the default)
convergence_threshold: -1 We intend to include those comments in the GUI, but that work has not yet been completed. |
The documentation for the bandpass filter is at https://fcp-indi.github.io/docs/latest/user/nuisance#temporal-filtering. It's filtering the data, and the always-selected thing is a bug. Until that bug is resolved, you can either
|
The documentation for erosion is pretty scattered. There's some in https://fcp-indi.github.io/docs/user/anat#anatomical-tissue-segmentation and some in https://fcp-indi.github.io/docs/user/nuisance#configuration-without-the-gui (the second link replicates the comments in the default pipeline YAML) Also,
|
Describe the bug
C-PAC GUI
It seems that GUI would save the config whoever used the GUI most recently. When open https://fcp-indi.github.io/C-PAC_GUI/, it showed a lot of config âDefault (2), Default (3), ... â which were created by someone else earlier. If the earlier user duplicated the default one but changed something, the name is still âDefault somethingâ. This could be confusing to the new user. It would be good to have a đ¸ Clean home page #132 with only âDefaultâ config showing there.
đ¸ The order of Tabs #133. Is the order of Tab somewhat reflect the order of the processing? For example. currently, nuisance regression is at the relative end of the options. Does it mean that all the Tabs before nuisance regression will run before nuisance regression? If not, it's probably better to arrange tabs, for example, from minimal preprocessing, preprocessing, postprocessing, to post-analysis.
Time series extraction: It is not clear at which step the time series is extracted,e.g. after minimal preprocessing, after nuisance regression, etc.? đ Clarify sequence of steps fcp-indi.github.io#267
Network centrality, ReHo, ALFF. Similar question, at which step these will be calculated?
Longitudinal template. No document for this option. I guess it is for the anatomical image across sessions?
Nuisance regression. 2-nuisance regression. What is the bandPass option here? Is it band-pass filtering on the regressor or just adds band-pass filtering to filter the data? Doesnât matter if selected or not, it always shows as selected.
Nuisance regression - Regressor mask. No document for this option. are the options âcsf_erosion_propâ, âcsf_mask_erosion_mmâ, âcsf_erosion_mmâ OR or AND? What does it mean âcsf_erosion_propâ? Use the probability map to threshold the mask? Or it means that keep e.g. 0.6 proportion of a given tissue mask that defined in the earlier step? And, default 30mm for âGM_mask_erosion_mmâ seems off, too big.
How can we select fork GSR and noGSR in the GUI? If canât do it in GUI, could we have đ More documentation / more links to documentation #134 in GUI to tell the user how to fork this option in the config?
Ting
To reproduce
Expected behavior
clear document/note
Acceptance criteria
clear document/note
Screenshots
Some one left the configs there
C-PAC version
No response
Container platform
Docker
Docker and/or Singularity version(s)
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: