Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linter in Julia #102

Open
albop opened this issue Jul 26, 2017 · 2 comments
Open

Linter in Julia #102

albop opened this issue Jul 26, 2017 · 2 comments

Comments

@albop
Copy link
Member

albop commented Jul 26, 2017

Clearly, a big barrier to wider adoption, is the fact that many errors in the yaml file, lead to seemingly random errors when solving the model. Many of these errors could be catched and exposed by a linter, like we do in Python.

I created a new branch https://github.com/EconForge/Dolo.jl/tree/linter , with a proof of concept.

I thought that @ezgioz could extend the proof of concept so as to cover most of the errors/warnings message that we cover in Python (https://github.com/EconForge/dolo/blob/master/dolo/linter.py). This could start by listing somewhere all the errors/warnings that we must check.

There are other issues for later (I suspect @sglyon might be curious about them):

  • how to integrate the linter to an editor workflow (calling cmd-line might be too slow)
  • the proof of concept operates on the EventTree produced by YAML.jl without constructing any object. This one keeps a marker with line/column of every node. It is not the same as what is stored in model.data although we might discuss at later stages whether merging both would be a good idea (concretely replacing model.data by a structure with lines/columns informations or with the EventTree itself). There might be problems as we sometimes want to modify YAML.jl at some point.
@sglyon
Copy link
Member

sglyon commented Jul 26, 2017

A linter would be great! @albop I think you forgot to push your changes to that branch -- it seems to match master on GitHub

@albop
Copy link
Member Author

albop commented Jul 26, 2017

Right ! I just added the linter.jl file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants