Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the toast notification #202

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dikshashukla455
Copy link
Contributor

Issue Number

fixes #201

Describe the changes you've made

I have added an error message which will be displayed along with an icon in the toast notification.

Describe if there is any unusual behavior (Any Warning) of your code(Write NA if there isn't)

NA

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • All new and existing tests passed.
  • The title of my pull request is a short description of the requested changes.

@codetheorem
Copy link
Member

I think it is better to show error message that backend sends rather than showing same error message for every action. We can update backend if it is showing the blank message.

@cyntss
Copy link
Member

cyntss commented Mar 28, 2022

I agree with @codetheorem

@dikshashukla455
Copy link
Contributor Author

Yeah, you are right. I don't know the backend part that's why I implemented in front end only.but I will try to work on this implementation in backend.
Thank you.

@dikshashukla455
Copy link
Contributor Author

Yeah, you are right. I don't know the backend part that's why I implemented in front end only.but I will try to work on this implementation in backend. Thank you.

@codetheorem you can also try on it. I mean my issue is open. Everyone can work on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error toast notification shows only 'X' icon with no message.
3 participants