Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick bank account by label name instead of address #5

Open
wiwichips opened this issue Jan 14, 2024 · 1 comment
Open

Pick bank account by label name instead of address #5

wiwichips opened this issue Jan 14, 2024 · 1 comment

Comments

@wiwichips
Copy link
Collaborator

Portal bank accounts are guaranteed to have a unique name,

well, there are some accounts which have multiple accounts with the same name, and technically you can create multiple accounts with the same name as theres no restriction on the backend, but we block the ability to create multiple bank accounts with the same name on the frontend and expect accounts to have a unique name

so we should allow the user to choose a bank account by its name "label" instead of account address. This is simpler and more congruent with the wallet api

@wiwichips
Copy link
Collaborator Author

will be closed by #9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant