Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for rotate images #11

Open
h2non opened this issue Mar 10, 2015 · 8 comments
Open

Support for rotate images #11

h2non opened this issue Mar 10, 2015 · 8 comments

Comments

@h2non
Copy link

h2non commented Mar 10, 2015

Firstly, thank you for this package.

It would be great if you can introduce support for images rotation. It can be done in VIPS.
Here is the API doc:
http://www.vips.ecs.soton.ac.uk/supported/current/doc/html/libvips/libvips-resample.html#vips-similarity

I think this is the only significant nice-to-have missing feature in the package

@h2non
Copy link
Author

h2non commented Mar 17, 2015

Rotate implementation from sharp:
https://github.com/lovell/sharp/blob/master/src/resize.cc#L217

@h2non h2non closed this as completed Mar 17, 2015
@h2non h2non reopened this Mar 17, 2015
@DAddYE
Copy link
Owner

DAddYE commented Mar 17, 2015

I will add it! Thanks!

@foresmac
Copy link

+1 on supporting rotation. I had planned to try and add support during our last hack days, but I ended up spending all my time working on my first Django ticket.

@h2non
Copy link
Author

h2non commented Apr 7, 2015

Due to personal requirements, I've created my own Go package called bimg, which is heavily inspired in sharp as well.

All of my proposed features are now supported in bimg:
https://github.com/h2non/bimg

@h2non h2non closed this as completed Apr 7, 2015
@foresmac
Copy link

foresmac commented Apr 7, 2015

We'd certainly entertain the idea of using bimg instead, but I'd rather keep this issue open as long as @DAddYE is willing to explore adding support to vips.

@h2non
Copy link
Author

h2non commented Apr 7, 2015

@foresmac I completely agree with you.

@h2non h2non reopened this Apr 7, 2015
@DAddYE
Copy link
Owner

DAddYE commented Apr 7, 2015

Yes I'm gonna add the support soon, I'm working on trimming which is a feature that I need in another project and I'm also working on improving performances and cpu/memory reduction (1st priority)

@foresmac
Copy link

Any progress on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants