Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpaceWars! example sections sometimes rely on refactoring before it has occured #40

Open
pwplusnick opened this issue Jul 24, 2024 · 2 comments
Assignees

Comments

@pwplusnick
Copy link
Contributor

pwplusnick commented Jul 24, 2024

I've been going through the book the last couple of nights, and following along. I'm nearing completion. It is an excellent resource! One thing I've noticed about the end of chapter SpaceWars example is that it will sometimes provide examples that would break the code if it were used in the state that the previous chapters had left it. For example, in Chapter 4 example 4.21, position is declared as a method variable, when it was previously left as an instance variable; in Chapter 5 example 5.10, it sends self morphPosition before the class is a PlacedMorph subclass.

I would be willing to go through the examples this weekend, and re-work the necessary code examples so that the same concepts are being driven, but the code only builds upon what was previously left rather than foreshadowing future refactors. Is this something that would be helpful?

@pwplusnick pwplusnick changed the title SpaceWars! example sections uses morphic messages before morphic is introduced SpaceWars! example sections sometimes rely on refactoring before it has occured Jul 24, 2024
@hilaire
Copy link
Collaborator

hilaire commented Aug 2, 2024

I will take a look. Thanks to report.

@hilaire
Copy link
Collaborator

hilaire commented Aug 2, 2024

Yes it will be very helpful to make the examples more consistent and less confusing for the reader.
Please go ahead
Thanks

@hilaire hilaire self-assigned this Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants