Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements DelaySubscription from #80 #81

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Jackstone92
Copy link

Here is a first draft proposal for a Combine DelaySubscription operator for the request in #80.
I would appreciate any thoughts and feedback!

@codecov
Copy link

codecov bot commented Mar 7, 2021

Codecov Report

Merging #81 (3d7f4b6) into main (5b8a0c0) will decrease coverage by 0.35%.
The diff coverage is 93.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
- Coverage   97.01%   96.66%   -0.36%     
==========================================
  Files          60       62       +2     
  Lines        3215     3594     +379     
==========================================
+ Hits         3119     3474     +355     
- Misses         96      120      +24     
Impacted Files Coverage Δ
Tests/DelaySubscriptionTests.swift 93.14% <93.14%> (ø)
Sources/Operators/DelaySubscription.swift 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b8a0c0...64ba6e8. Read the comment docs.

@jasdev
Copy link
Member

jasdev commented Apr 16, 2021

Really wicked! I’ll let @freak4pc chime in here, but for a related tangent, it’s neat to see how the PF duo pulled this off as a composed operator in pointfreeco/isowords#94

@freak4pc
Copy link
Member

@jasdev To be honest I've found myself just using delay with flatMap instead of delaySubscription for quite a lot of times in Rx :)

Anyways, I'll try to dig into this a bit later. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants