Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration with other vectorDbs [enhancement] #496

Open
PrashantDixit0 opened this issue Dec 2, 2023 · 16 comments
Open

Integration with other vectorDbs [enhancement] #496

PrashantDixit0 opened this issue Dec 2, 2023 · 16 comments
Labels
enhancement New feature or request

Comments

@PrashantDixit0
Copy link
Contributor

@mrT23 @okotek
Are you open to Integrate with other VectorDbs for giving flexibility to user to use PR-agent with any vectorDb of their choice?

I can work on integrating with ChromaDB and LanceDB for scalibility.
Please let me know, What are your thoughts on this.

@mrT23
Copy link
Collaborator

mrT23 commented Dec 2, 2023

/similar_issue

Copy link
Contributor

github-actions bot commented Dec 2, 2023

@PrashantDixit0
Copy link
Contributor Author

I want to add it as an enhancement. Are you open to merge PR, If I create one for integrating other vectorDBs.

@PrashantDixit0 PrashantDixit0 changed the title Integration with other vectorDbs Integration with other vectorDbs [enhancement] Dec 2, 2023
@coditamar
Copy link
Contributor

I want to add it as an enhancement. Are you open to merge PR, If I create one for integrating other vectorDBs.

Are you relating to the usage of the vectorDB in the /similar_issue command/feature?
Or do you have a new feature/command in mind?

@PrashantDixit0
Copy link
Contributor Author

I want to add LanceDB and ChromeDB also as a vectorDB with Pinecone.

Results from /similiar_issues are not what I have in my mind

@coditamar
Copy link
Contributor

I want to add LanceDB and ChromeDB also as a vectorDB with Pinecone.

Results from /similiar_issues are not what I have in my mind

Can you please clarify how will these vectorDB used?

@PrashantDixit0
Copy link
Contributor Author

Same as Pinecone, they'll used for semantic searching and filtering similar PRs and Issues

@mrT23
Copy link
Collaborator

mrT23 commented Dec 2, 2023

@PrashantDixit0
Thanks for the suggestion.

We are open to adding another vectorDb provider.
I would recommend focusing on a single one at the first stage.

i just want to emphasize this is not an easy task.
The main challenge here is not actually doing the semantic search, but seamlessly managing the database.
You need to decide, each time a user comments /similar_issue, if to build a fresh new database, or just update the existing one, and with what. This should be done efficiently and gracefully, and requires deep understanding of how the vectorDb is managed and can be handled.

@mrT23 mrT23 added the enhancement New feature or request label Dec 2, 2023
@PrashantDixit0
Copy link
Contributor Author

@mrT23 Yes agree with you, I'll work on it and raise a PR soon.

Thank you for considering my suggestion ☺️

@mrT23
Copy link
Collaborator

mrT23 commented Dec 2, 2023

Sure. Feel free to ask questions and consult

@PrashantDixit0
Copy link
Contributor Author

Yes I'll update the progress on it with you

@PrashantDixit0
Copy link
Contributor Author

@mrT23 I have completed the Integration with LanceDB #523 . Please review it once

@mrT23
Copy link
Collaborator

mrT23 commented Dec 14, 2023

Similar Issues


@PrashantDixit0
Copy link
Contributor Author

@PrashantDixit0
Copy link
Contributor Author

PrashantDixit0 commented Dec 24, 2023

@mrT23 I have created an updated PR #548 and kept all the comments you gave previously. Please review it once again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants
@mrT23 @PrashantDixit0 @coditamar and others