Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog commit message always includes "[skip ci]" #1358

Open
denisrevduplo opened this issue Nov 14, 2024 · 3 comments
Open

Changelog commit message always includes "[skip ci]" #1358

denisrevduplo opened this issue Nov 14, 2024 · 3 comments
Labels

Comments

@denisrevduplo
Copy link

When using "/update_changelog --pr_update_changelog.push_changelog_changes=true"
as part of a merge having "[skip ci] Update CHANGELOG.md" added as a commit in the merge branch can prevent actions from running. This prevents checks from passing.

Please make the commit message configurable, or add a way to disable adding [skip ci] every time in the commit msg.

@mrT23
Copy link
Collaborator

mrT23 commented Nov 14, 2024

This was a direct request from the community, to avoid chain of infinite pipelines:

#857
#1185

You are welcome to open a PR making it configurable

@mrT23 mrT23 added the answered label Nov 14, 2024
@denisrevduplo
Copy link
Author

To add more context, the way we prevent the infinite pipeline issue is we already have a path filter in our actions:

 paths-ignore:
      - '**.md'

@mrT23
Copy link
Collaborator

mrT23 commented Nov 14, 2024

but that for specific file types and also requires an active change from the user.
[skip ci] is a general solution by pr-agent (that indeed may sometimes be unwanted)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants