Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Failed to load/ Error widget #84

Open
abstrekt opened this issue Mar 27, 2021 · 3 comments · Fixed by #134
Open

Missing Failed to load/ Error widget #84

abstrekt opened this issue Mar 27, 2021 · 3 comments · Fixed by #134
Labels
good first issue Good for newcomers

Comments

@abstrekt
Copy link
Member

Describe the bug
Should be a proper view if content failed to load due to some error like no internet or something

To Reproduce
Steps to reproduce the behaviour:
Turn off internet & load something.

Screenshots
If applicable, add screenshots to help explain your problem.

Device Information [optional]:

  • OS: Android

Additional context
No

Are you working on this issue? (Yes/No)
No

@Aadeesh11
Copy link
Contributor

Hello, Is this issue still open? @manjotsidhu

@Aadeesh11
Copy link
Contributor

Please guide me how should I proceed to solve this issue?

@manjotsidhu
Copy link
Member

manjotsidhu commented Dec 5, 2021

@Aadeesh11 You will need to implement changes done in #134 (later on they were reverted due to failing tests) and also fix UI Tests. Make sure all the error codes are properly handled with messages. Also make sure error widgets are implemented in all screens where APIs are being called.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
3 participants