Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removes additional bg-color for navbar on dark mode #357

Merged
merged 1 commit into from
Nov 10, 2023
Merged

removes additional bg-color for navbar on dark mode #357

merged 1 commit into from
Nov 10, 2023

Conversation

Murdock9803
Copy link
Contributor

Fixes #355

Changes done:

  • The white background color is removed for smaller screens (max-width : 768px)

Screenshots:

initial state of navbar (before changes) :
initial

final state of navbar (after changes) :
final

Preview Link(s): https://github.com/Murdock9803/CircuitVerseDocs/blob/e888a3fd1fbbc67ca6588877081afff40531539a/docs/styles/theme.css

✅️ By submitting this PR, I have verified the following

  • Checked to see if a similar PR has already been opened 🤔️
  • Reviewed the contributing guidelines 🔍️
  • Sample preview link added (add a link from the checks tab after checks complete)
  • Tried Squashing the commits into one

Copy link

netlify bot commented Nov 7, 2023

Deploy Preview for cv-doc ready!

Name Link
🔨 Latest commit e888a3f
🔍 Latest deploy log https://app.netlify.com/sites/cv-doc/deploys/654a075a1e450f0008b4f291
😎 Deploy Preview https://deploy-preview-357--cv-doc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Murdock9803
Copy link
Contributor Author

This is my first open source contribution, any help and guidance on errors would be greatly appreciated.

@tachyons tachyons merged commit 3500b97 into CircuitVerse:master Nov 10, 2023
6 of 14 checks passed
@tachyons
Copy link
Member

Thanks @Murdock9803

@Murdock9803
Copy link
Contributor Author

Its my pleasure. looking forward for more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The navbar turns white on smaller screens when in dark mode.
3 participants