Better Integration to third party applications #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Scott-David Jones <[email protected]>
Pass parameter functionality to allow api to be included as part of standard composer dependencies, not requiring change of default configs and allowing user to pass parameters. - sdk/autoload.php - added autoload of new AbstractPoint.php - AbstractPoint.php - condensed duplicated code from child points. - CDSApiClient.php - pass in curl options. Allow the user to specify curl options - CDSApiSoapRequest.php - Current PreProd only allows SSL version 1 and Live allows SSL Version 4. This fixes the need to hard code versions between dev and live systems. Defaults to live version of parameters. Signed-off-by: Scott-David Jones <[email protected]>
Signed-off-by: Scott-David Jones <[email protected]>
Signed-off-by: Scott-David Jones <[email protected]>
Signed-off-by: Scott-David Jones <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of applications use their own configuration fiels (Laravel, craft etc)
The changes here allow a user to pass in parameters rather than rely on a config file in their vendor directory - which will be overwritten on update. User can pass:
I have added default cURL options but allowed the user to overwrite them due to differences in the preprod and live systems for exampel preprod does not like cURL version 4 and wont work if that is supplied (Version 1 is required).
I have also condensed some (not all) common functionality (AbstractPoint) for easier maintainability.