Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dlt-load-control bugs #685

Open
alexmohr opened this issue Oct 11, 2024 · 0 comments
Open

dlt-load-control bugs #685

alexmohr opened this issue Oct 11, 2024 · 0 comments

Comments

@alexmohr
Copy link
Contributor

We found some issues internally and I'll provide fixes as soon as they are tested.
I'm opening this issue to communicate them, so other potential issues can be added here.

  1. trace load limits is creating a large cpu load when a lot of context ids are filtered.
  2. trace load limits lookup is not correct
DltTraceLoadSettings*
dlt_find_runtime_trace_load_settings(DltTraceLoadSettings *settings, uint32_t settings_count, const char* apid, const char* ctid) {
    if ((apid == NULL) || (strlen(apid) == 0))
        return NULL;

    DltTraceLoadSettings* app_level = NULL;
    size_t ctid_len = (ctid != NULL) ? strlen(ctid) : 0;

    for (uint32_t i = 0; i < settings_count; ++i) {
        if (strncmp(apid, settings->apid, DLT_ID_SIZE) != 0) {

the last line in the snippet should be

        if (strncmp(apid, settings[i].apid, DLT_ID_SIZE) != 0) {

instead of always comparing against the first element in the array.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant