Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

May or may not be of concern: some functions will only work if input data is ordered in a particular way #7

Open
CesileyKing opened this issue Aug 14, 2023 · 0 comments

Comments

@CesileyKing
Copy link
Contributor

CesileyKing commented Aug 14, 2023

  1. ‘generate_focal_plane_distribution’ (MMTModules.py, lines 1081-1104) assumes that detector data is ordered in the following frequency/polarization angle combinations: freq1/polX, freq1/polY, freq2/polX, freq2/polY. When I was playing with MMT, I modified this to only increment index i by 1 and read in each detector’s info one at a time, instead of 4 at a time.

  2. ‘calculate_beam_matrix’ (MMTModules.py, lines 700-710) assumes that detectors located at an even index in the dictionary have polarization angles of 0 or pi/4, and detectors located at an odd index in the dictionary are pi/2 or -pi/4. When I was playing with MMT, I modified this to check the detector IDs to determine polarization angle (but this was particular to how I was labeling detectors, so one would probably want however S4 plans to standardly label detectors).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant