vuln-fix: Temporary Directory Hijacking or Information Disclosure

This fixes either Temporary Directory Hijacking, or Temporary Directory Local Information Disclosure. Weakness: CWE-379: Creation of Temporary File in Directory with Insecure Permissions Severity: High CVSSS: 7.3 Detection: CodeQL & OpenRewrite (https://public.moderne.io/recipes/org.openrewrite.java.security.UseFilesCreateTempDirectory) Reported-by: Jonathan Leitschuh <[email protected]> Signed-off-by: Jonathan Leitschuh <[email protected]> Bug-tracker: JLLeitschuh/security-research#10 Co-authored-by: Moderne <[email protected]>
BulkSecurityGeneratorProjectV2 · Oct 4, 2022 · 965a2d8 · 965a2d8
1 parent e635c89
commit 965a2d8
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/src/test/java/com/tamingtext/classifier/bayes/ExtractTrainingDataTest.java b/src/test/java/com/tamingtext/classifier/bayes/ExtractTrainingDataTest.java
@@ -24,6 +24,7 @@
 import java.io.FileInputStream;
 import java.io.IOException;
 import java.io.InputStreamReader;
+import java.nio.file.Files;
 import java.util.HashMap;
 import java.util.Map;
 
@@ -54,9 +55,7 @@ public static void beforeClass() throws Exception {
   }
 
   public static File createTempDirectory() throws IOException {
-    File file = File.createTempFile("extract-test", "test");
-    file.delete();
-    file.mkdirs();
+    File file = Files.createTempDirectory("extract-test" + "test").toFile();
     if (!file.isDirectory()) {
       throw new IOException("Could not create temporary directory: " + file);
     }