Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Basilisp file extension to Calva Spritz #2628

Merged
merged 5 commits into from
Sep 22, 2024

Conversation

alendit
Copy link
Contributor

@alendit alendit commented Sep 21, 2024

What has changed?

Calva supports many different runtimes, e.g. basilisp, via nrepl. However, Spritz doesn't recognize some of its extension.

This change syncs the extensions between package.json and Spritz's package.json to enable notebook support for more file types. In particular, I add the following extensions clojure, joke, fiddle, ly, and lpy.

Fixes #2629

My Calva PR Checklist

I have:

  • Read How to Contribute.
  • Directed this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • Made sure I have changed the PR base branch, so that it is not published. (Sorry for the nagging.)
  • Made sure there is an issue registered with a clear problem statement that this PR addresses, (created the issue if it was not present).
    • Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.
  • Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and either tested it there if so, or mentioned it in the PR.
  • Added to or updated docs in this branch, if appropriate
  • Tests
    • Tested the particular change
    • Figured if the change might have some side effects and tested those as well.
  • Formatted all JavaScript and TypeScript code that was changed. (use the prettier extension or run npm run prettier-format)
  • Confirmed that there are no linter warnings or errors (use the eslint extension, run npm run eslint before creating your PR, or run npm run eslint-watch to eslint as you go).

Ping @PEZ, @bpringe, @corasaurus-hex, @Cyrik

Calva supports basilisp via nrepl. However, Spritz doesn't recognize its extension.
Copy link

netlify bot commented Sep 21, 2024

Deploy Preview for calva-docs ready!

Name Link
🔨 Latest commit c500e47
🔍 Latest deploy log https://app.netlify.com/sites/calva-docs/deploys/66eff3bdcf985600089ee709
😎 Deploy Preview https://deploy-preview-2628--calva-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PEZ PEZ changed the base branch from published to dev September 22, 2024 07:24
@PEZ
Copy link
Collaborator

PEZ commented Sep 22, 2024

Hello. Thanks for the PR! 🙏 I note that there are more discrepancies between the two manifests. I created an issue for it now. Maybe you can close that issue with this PR?

Also, please include the PR template again and go through the items in the checklist. (I've retargeted this PR at dev already, so that we don't accidentally merge it to published, which is known to have happened and it causes a lot of extra work for me.)

@PEZ
Copy link
Collaborator

PEZ commented Sep 22, 2024

Thanks for updating! I think .fiddle files are still lacking in the pattern.

Also, the changelog isn't updated yet. The release script needs that to know what to put in the release notes.

@alendit
Copy link
Contributor Author

alendit commented Sep 22, 2024

Hi @PEZ, yeah, somehow the codespaces didn't commit the CHANGELOG change.

I wasn't sure if .fiddle makes sense in the context of notebooks, but I can add it.

@alendit
Copy link
Contributor Author

alendit commented Sep 22, 2024

Turns out you need to explicitly push from the codespace.

Should I add .fiddle?

@alendit
Copy link
Contributor Author

alendit commented Sep 22, 2024

Added fiddle, as well.

CHANGELOG.md Outdated Show resolved Hide resolved
@PEZ
Copy link
Collaborator

PEZ commented Sep 22, 2024

Awesome! I don't use notebooks a lot, but intuitively fiddle files and notebooks go together like a horse and carriage. =)

@PEZ PEZ merged commit 423dfc7 into BetterThanTomorrow:dev Sep 22, 2024
5 checks passed
@PEZ PEZ linked an issue Sep 22, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Synchronize the file extensions for Calva and Calva Spritz
2 participants