-
-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Basilisp file extension to Calva Spritz #2628
Conversation
Calva supports basilisp via nrepl. However, Spritz doesn't recognize its extension.
✅ Deploy Preview for calva-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hello. Thanks for the PR! 🙏 I note that there are more discrepancies between the two manifests. I created an issue for it now. Maybe you can close that issue with this PR? Also, please include the PR template again and go through the items in the checklist. (I've retargeted this PR at |
Thanks for updating! I think Also, the changelog isn't updated yet. The release script needs that to know what to put in the release notes. |
Hi @PEZ, yeah, somehow the codespaces didn't commit the CHANGELOG change. I wasn't sure if |
Turns out you need to explicitly push from the codespace. Should I add |
Added fiddle, as well. |
Awesome! I don't use notebooks a lot, but intuitively fiddle files and notebooks go together like a horse and carriage. =) |
What has changed?
Calva supports many different runtimes, e.g. basilisp, via nrepl. However, Spritz doesn't recognize some of its extension.
This change syncs the extensions between
package.json
and Spritz'spackage.json
to enable notebook support for more file types. In particular, I add the following extensions clojure, joke, fiddle, ly, and lpy.Fixes #2629
My Calva PR Checklist
I have:
dev
branch. (Or have specific reasons to target some other branch.)published
. (Sorry for the nagging.)[Unreleased]
entry inCHANGELOG.md
, linking the issue(s) that the PR is addressing.npm run prettier-format
)npm run eslint
before creating your PR, or runnpm run eslint-watch
to eslint as you go).Ping @PEZ, @bpringe, @corasaurus-hex, @Cyrik