Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow node timeout/failure errors not reflected in ApplicationGroup status #289

Open
nitishm opened this issue Jun 8, 2021 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@nitishm
Copy link
Contributor

nitishm commented Jun 8, 2021

Describe the bug
Failures and timeouts that occur during a workflow node execution are not reflected by the ApplicationGroup status.
A timeout failure resulted in a nil error message

│ status:                                                                                                                                                                                                      │
│   conditions:                                                                                                                                                                                               │
│   - lastTransitionTime: "2021-06-08T14:55:13Z"                                                                                                                                                               
│     **message: 'workflow in failure/error condition : %!w(<nil>)'**                                                                                                                                              
│     reason: Failed                                                                                                                                                                                           
│     status: "True"                                                                                                                                                                                           
│     type: Ready                                                                                                                                                                                              
│   - lastTransitionTime: "2021-06-08T13:48:32Z"                                                                                                                                                               
│     message: application group reconciliation succeeded                                                                                                                                                      
│     reason: Succeeded                                                                                                                                                                                        
│     status: "True"                                                                                                                                                                                           
│     type: Deploy

To Reproduce
Steps to reproduce the behavior:
Havent tried this since it was seen in the field but let me device a way to do this locally.

Expected behavior
A clear and concise description of what you expected to happen.
Error message should be reflected stating why the ApplicationGroup reconciliation failed.

Screenshots
If applicable, add screenshots to help explain your problem.

Environment (please complete the following information):

  • Kubernetes Version [e.g. 1.21.0]
  • Kubernetes Distro [e.g. AKS, GKE, etc.]
  • Orkestra Version Tag
  • Helm Version

Additional context
Add any other context about the problem here.

@nitishm nitishm added the bug Something isn't working label Jun 8, 2021
@jonathan-innis
Copy link
Contributor

This one could be captured here #313. Haven't made the fix yet but do you have a good idea of how to capture the logs from the workflow step? This could potentially be put into the workflow condition object

@nitishm nitishm added this to the Milestone #2 milestone Jun 14, 2021
@nitishm
Copy link
Contributor Author

nitishm commented Jun 23, 2021

Additionally we should also add event generation to the workflow executor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants