Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASO should help the user manage CRD storedVersions #4376

Open
matthchr opened this issue Oct 24, 2024 · 0 comments
Open

ASO should help the user manage CRD storedVersions #4376

matthchr opened this issue Oct 24, 2024 · 0 comments
Assignees
Milestone

Comments

@matthchr
Copy link
Member

Describe the current behavior
If we deprecate a CRD version that was at one point the storage version (in storedVersions field of CRD status), the user/ASO itself will be unable to update their CRDs. An example of this happened in 2.9.0 with v1api20230202preview of containerservice.

Describe the improvement
We should've supported cleanup up storedVersions via asoctl in the above case, but in the mode where ASO installs its own CRDs we also should just manage this oureslves so that users don't have to fiddle with storedVersions.

We could take a page from Karpenter and do something like this: kubernetes-sigs/karpenter#1689 - or if not a controller (which may not be fully necessary for our case) we could do this checking during or before CRD installation.

An implementation note is that it should probably share logic with asoctl.

Additional context
Add any other context about the suggested improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant