Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow deletion of resources with AzureName empty #4307

Open
theunrepentantgeek opened this issue Sep 30, 2024 · 0 comments · May be fixed by #4460
Open

Allow deletion of resources with AzureName empty #4307

theunrepentantgeek opened this issue Sep 30, 2024 · 0 comments · May be fixed by #4460
Assignees
Milestone

Comments

@theunrepentantgeek
Copy link
Member

Describe the current behavior

The AzureName of every resource should be set automatically by our webhook, but if that fails we can end up with resources where AzureName is empty. This results in an invalid ARM resource URL, resulting in an error when someone tries to delete the resource.

Describe the improvement

When AzureName is empty (and therefore when any generated ARM resource ID will be invalid by definition), skip the attempt to delete the Azure resource and allow deletion of the cluster resource to proceed. (This would have enabled easier recovery for #4285.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants