Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F-Droid inclusion #40

Closed
Poussinou opened this issue May 4, 2022 · 36 comments · Fixed by #116
Closed

F-Droid inclusion #40

Poussinou opened this issue May 4, 2022 · 36 comments · Fixed by #116
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Poussinou
Copy link
Contributor

Hi,

Since this app is GNU GPL v3 licensed, are you considering the fact to add it to F-Droid? There is a strong community behind.

You can find some documentation here.

Otherwise, if you don't want to work on the inclusion of this app by yourself, are you still ok with the integration of this app in F-Droid repo ?

@Poussinou Poussinou added the enhancement New feature or request label May 4, 2022
@Ashinch
Copy link
Owner

Ashinch commented May 4, 2022

A user open an RFP for me earlier (thanks) and I would like to be able to add it to F-Droid, so I created Fastlane.

But I don't have much time to deal with that aspect at the moment, maybe someone else can open a merge request at fdroiddata and maybe I'll take the time to deal with it, too.

@Ashinch Ashinch added the help wanted Extra attention is needed label May 4, 2022
@Ashinch Ashinch pinned this issue May 5, 2022
@qso0
Copy link

qso0 commented May 8, 2022

Maybe @linsui can help with this.

@linsui
Copy link

linsui commented May 8, 2022

Wow, it looks beautiful! I‘ll have a try.

@linsui
Copy link

linsui commented May 8, 2022

The app is awesome! Looking forward to getting more function.

@Ashinch Could you please embed the ToS in the apk? I would say it's weird that I have to open Gitee to know that the app doesn't track me.

The app check update on start without any action. So as soon as I start it it connects to github/gitee. This doesn't make sense for F-Droid users. I'll remove these chechupdate in F-Droid build or even better you can add a flavor for F-Droid without update check.

Thanks!

@Ashinch
Copy link
Owner

Ashinch commented May 10, 2022

Hi @linsui,

Thank you for your help.

I pushed a flavors branch (#59 ), you see if it meets the requirements.

@linsui
Copy link

linsui commented May 10, 2022

Thanks! Could you please also embed the ToS?

@Ashinch
Copy link
Owner

Ashinch commented May 10, 2022

@linsui

Thanks! Could you please also embed the ToS?

Of course, ToS still needs some work, such as a page.

If this branch (#59) is OK, then I will merge it.

@linsui
Copy link

linsui commented May 10, 2022 via email

@licaon-kter
Copy link
Contributor

@Ashinch any news on the ToS inclusion? The app appears ready to merge but it will get AntiFeature: NonFreeNet if it needs an external proprietary server to show a bit of text. :(

@Ashinch
Copy link
Owner

Ashinch commented Jun 16, 2022

@licaon-kter I will include the built-in ToS soon, should be in the next few days.

@Ashinch
Copy link
Owner

Ashinch commented Jun 16, 2022

#113

The latest main branch already includes a built-in ToS.

@linsui
Copy link

linsui commented Jun 16, 2022

Thanks! The MR is merged. ReadYou will be available on F-Droid in a week.

@Ashinch
Copy link
Owner

Ashinch commented Jun 16, 2022

@linsui Thank you all very much for your help! ❤️

@daffydock
Copy link

It is on F-Droid. Congrats.

@linsui
Copy link

linsui commented Jun 22, 2022

Here is the F-Droid badge:

[<img src="https://fdroid.gitlab.io/artwork/badge/get-it-on.png"
    alt="Get it on F-Droid"
    height="80">](https://f-droid.org/packages/me.ash.reader)

Get it on F-Droid

@Ashinch
Copy link
Owner

Ashinch commented Jun 22, 2022

@linsui Thank you very much, I will change the README soon.

@jcperil
Copy link

jcperil commented Apr 4, 2023

As it has been solved, you can unpin this issue.

@CeruleanDerpo
Copy link

The last three updates still aren't on f-droid, is it an f-droid issue or something else?

@licaon-kter
Copy link
Contributor

0.9.10 is live already, update you index in Client (pull to refresh) 😉

@CeruleanDerpo
Copy link

CeruleanDerpo commented Jan 16, 2024

Found it. It was an issue on my end (I probably installed it from GitHub and now it is incompatible with the f-droid version so the update wasn't being recommended to me), sorry.

@candideu
Copy link

Hi! Looks like the latest release hasn't reached F-droid yet

@linsui
Copy link

linsui commented Feb 11, 2024

Hi, it will be published soon.

@xuangeyouneihan
Copy link

Hi! Looks like v0.10.0 hasn't reached F-droid yet

@Ashinch
Copy link
Owner

Ashinch commented Jun 3, 2024

Hi! Looks like v0.10.0 hasn't reached F-droid yet

Hi, @xuangeyouneihan

F-Droid release channel requires manual pushing.

Hi, @linsui

I would like to request skipping version 0.10.0 and instead pushing the update to F-Droid after version 0.10.1 is released. There is a serious bug in version 0.10.0 that causes crashes for early users.

Thank you very much!

@linsui
Copy link

linsui commented Jun 3, 2024

Hi! Looks like v0.10.0 hasn't reached F-droid yet

Hi, of course, F-Droid update process takes about 3 days generally.

I would like to request skipping version 0.10.0 and instead pushing the update to F-Droid after version 0.10.1 is released. There is a serious bug in version 0.10.0 that causes crashes for early use

No problem.

@licaon-kter
Copy link
Contributor

@xuangeyouneihan

Hi! Looks like v0.10.0 hasn't reached F-droid yet

https://gitlab.com/fdroid/wiki/-/wikis/FAQ#how-long-does-it-take-for-my-app-to-show-up-on-website-and-client

@Ashinch

F-Droid release channel requires manual pushing.

fyi, the app is on "autoupdate": https://gitlab.com/fdroid/fdroiddata/-/commit/c6b69c516a9cdda5bddda8c72ad4def19690250b

@licaon-kter
Copy link
Contributor

I've disabled 0.10.0 https://gitlab.com/fdroid/fdroiddata/-/commit/4d65f2e9c71f1c40d52af785f6125dfe9e58e0c9

@shuvashish76
Copy link

#703 (comment)

Please do make the update checker opt-in for F-Droid & if possible remove unsplash connection. Thanks.

@licaon-kter
Copy link
Contributor

@licaon-kter
Copy link
Contributor

@shuvashish76 where is the updater in the UI exactly?

@Ashinch
Copy link
Owner

Ashinch commented Jun 4, 2024

@shuvashish76 where is the updater in the UI exactly?

  1. The F-Droid build variant of ReadYou does not check for updates.
  2. images.unsplash.com is used to display a placeholder image from the internet in preview styles. ReadYou will remove it and replace it with static images in future versions.
  3. besticon-demo.herokuapp.com is used to fetch website icons for feeds. This is an API on the internet. ReadYou will remove it and replace it with a local implementation in future versions.

@licaon-kter
Copy link
Contributor

@Ashinch thanks for fixing them, ping us when these are removed so we can remove the NonFreeNet flag

@Ashinch
Copy link
Owner

Ashinch commented Jun 5, 2024

Hi, @linsui @licaon-kter

Version 0.10.1 has been released.

BTW, images.unsplash.com has been removed.

@licaon-kter
Copy link
Contributor

@Ashinch
Copy link
Owner

Ashinch commented Aug 12, 2024

  1. besticon-demo.herokuapp.com is used to fetch website icons for feeds. This is an API on the internet. ReadYou will remove it and replace it with a local implementation in future versions.

The besticon-demo.herokuapp.com has been removed in #817.

@licaon-kter
Copy link
Contributor

@Ashinch ping when release is tagged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.