more mining stats #471
Draft
more mining stats #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Lev Berman <[email protected]> Co-authored-by: Amin Arria <[email protected]> Co-authored-by: Esteban Dimitroff Hódi <[email protected]>
Make it record h/s (not MiB/s) as documented in the declaration; set it to 0 when mining is paused.
but ar_coordinated_mining_tests does)
Refactor ar_mining_server.erl and ar_coordination.erl: 1. Intrdoduce 2 records to encapsulate the long argument lists (ar_mining_candidate, and ar_mining_solution) 2. Introduce common functions to remove duplicate code This is a first pass and tests fail. Next commits will fix tests and add more.
Some small bug fixes, and also better session management when computing H2 for a peer (i.e. assume we have a valid mining session if the request came from a peer)
…ar_test_node.erl and bin/test. Instead of using test_on_fork(), tests can use ar_test_node:test_with_mocked_function() Also get rid of a bunch of debugging output
…slave_node() in a couple areas.
…ead of slave_node() in a couple areas.
Fix off-by-one error when selecting partitions to mine
is calculatd automatically. Previously that logic was tied to free memory which can vary significantly and can cause the limit to be set too low. With this PR it is tied to total memory which is a stable value
1. copy genesis data with packing `any` 2. restart the ar_data_sync processes 3. copy genesis data into each configured storage_module without this 2 step process a test node with both spora_2_5 and spora_2_6 storage modules will not sync data for all storage modules
…ny` 2. restart the ar_data_sync processes 3. copy genesis data into each configured storage_module
…ny` 2. restart the ar_data_sync processes 3. copy genesis data into each configured storage_module
…king `any` 2. restart the ar_data_sync processes 3. copy genesis data into each configured storage_module
from mining. Since that partition may be incomplete it provides a mining advantage (e.g. it can fit in RAM), and we don't want to over-incentivize syncing the last partition.
The ar_pricing_tests are calibrated to this value so it's easier to stick with it. Only change needed is to update the ar_test_node launch sequence to not wait for partial chunks to be synced (since they won't hit the ar_sync_record)
out why they are causing other tests to fail
are calibrated for that number). Tests that need a different size (e.g. ar_mining_io_tests, ar_mining_server_tests) can set the storage modules explicitly.
it from the ar_mining_server critical path
merge master branch into feature/coordinated-mining-v5
as before it passes locally when run alone, will see if it still fails as part of the full test run
JamesPiechota
force-pushed
the
feature/coordinated-mining_v5
branch
from
7d10818
to
935aa07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.