Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS X 64 bit ARM download button shown when no ARM #326

Open
locobastos opened this issue Feb 27, 2023 · 3 comments
Open

OS X 64 bit ARM download button shown when no ARM #326

locobastos opened this issue Feb 27, 2023 · 3 comments

Comments

@locobastos
Copy link

Hello,

Context
Using v2.1.3 application, and uploading only OS X 64 bit Intel applications, when going on the page to download my app, I've a big green non-working button to download my app on the wrong processor.

Steps to reproduce

  • Install v2.1.3
  • Compile any Electron App for OS X 64-bit Intel processor
  • Add new Flavor (Ex: MyApp1)
  • Add new version (Ex: 1.0.0)
  • Upload previously compiled asset using the platform "OS X 64 bit Intel"

With an Intel OS X, go to https:///release/stable/MyApp1/

Expected result

  • A working button to download "OS X 64 bit Intel" application

Actual result

  • A non-working button "OS X 64 bit ARM", not doing anything when clicking on it (certainly because no asset exists)
@AnassDriate
Copy link

Same issue Here.

Would be great to propose Intel and ARM (as windows 32 & 64) if it not possible to detect automatically.

@liyaquath-code
Copy link

Same issue here.
Also the artifacts for arm64 is being published as x64. It seems ERS is not able to differentiate the processor / chip for mac devices.

npm run publish -- --arch=arm64,x64 --skip-package // publishes arm64 artifacts as x64
npm run publish -- --arch=x64 --skip-package // works fine
npm run publish -- --arch=arm64 --skip-package // publishes arm64 artifacts as x64

Screenshot 2023-04-23 at 5 24 47 PM

@liyaquath-code
Copy link

Issue is on @electron-forge/publisher-electron-release-server package see issue #3225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants