You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It appears to me that there is a plausible scenario in which there will be a divide by zero in calc_failure(), leading to unexpected results or a crash. During calibrate_arm_range(), if a user is is distracted and pushes the test button twice without moving the arm, max_arm_pos can be set to the same value as min_arm_pos. I suggest more checks before the calibrated variable is set to true.
The text was updated successfully, but these errors were encountered:
It appears to me that there is a plausible scenario in which there will be a divide by zero in calc_failure(), leading to unexpected results or a crash. During calibrate_arm_range(), if a user is is distracted and pushes the test button twice without moving the arm, max_arm_pos can be set to the same value as min_arm_pos. I suggest more checks before the calibrated variable is set to true.
The text was updated successfully, but these errors were encountered: