Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix added validation Issue #31 #42

Merged

Conversation

sadath2001
Copy link
Contributor

@sadath2001 sadath2001 commented Oct 2, 2024

Hi,

Regarding issue #31
I have added validation for checking if the ingredients and steps are populated fore adding next steps and ingredients.
Also added nodemon instead of node as its more efficient while testing out.

Kindly add this under gssoc ext and hacktober

Copy link

netlify bot commented Oct 2, 2024

Deploy Preview for delightful-daifuku-a9f6ea canceled.

Name Link
🔨 Latest commit 8b39b2d
🔍 Latest deploy log https://app.netlify.com/sites/delightful-daifuku-a9f6ea/deploys/67000ed9944c7700080e3435

@sadath2001
Copy link
Contributor Author

Hi @AlfiyaSiddique , kindly let me know if any changes needed.
also kindly add gssoc extended and hacktober fest in this PR.
thanks.

removed extra lines
removed console.log wherever i had added for testing purposes
@sadath2001 sadath2001 changed the title Bug fix added validation Bug fix added validation Issue #31 Oct 3, 2024
@AlfiyaSiddique AlfiyaSiddique self-requested a review October 3, 2024 17:09
@AlfiyaSiddique AlfiyaSiddique added gssoc-ext For GSSOC Extended Contribution. hacktoberfest-accepted labels Oct 3, 2024
backend/package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@AlfiyaSiddique
Copy link
Owner

@sadath2001 Some Comments.
Please fix them all

removed the console.log
Changed start back to node from nodemon
reverted back
Copy link
Contributor Author

@sadath2001 sadath2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the required things as requested

@AlfiyaSiddique AlfiyaSiddique added the level 1 GSSOC level 1 Contribution - 10 points label Oct 4, 2024
@AlfiyaSiddique AlfiyaSiddique merged commit 56f0a55 into AlfiyaSiddique:master Oct 4, 2024
5 checks passed
@sadath2001 sadath2001 deleted the bug_fix-added_validation branch October 4, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc-ext For GSSOC Extended Contribution. hacktoberfest-accepted level 1 GSSOC level 1 Contribution - 10 points
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants