-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix added validation Issue #31 #42
Merged
AlfiyaSiddique
merged 11 commits into
AlfiyaSiddique:master
from
sadath2001:bug_fix-added_validation
Oct 4, 2024
Merged
Bug fix added validation Issue #31 #42
AlfiyaSiddique
merged 11 commits into
AlfiyaSiddique:master
from
sadath2001:bug_fix-added_validation
Oct 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for delightful-daifuku-a9f6ea canceled.
|
Hi @AlfiyaSiddique , kindly let me know if any changes needed. |
removed extra lines
removed console.log wherever i had added for testing purposes
sadath2001
changed the title
Bug fix added validation
Bug fix added validation Issue #31
Oct 3, 2024
AlfiyaSiddique
added
gssoc-ext
For GSSOC Extended Contribution.
hacktoberfest-accepted
labels
Oct 3, 2024
@sadath2001 Some Comments. |
removed the console.log
Changed start back to node from nodemon
reverted back
removed
removed
sadath2001
commented
Oct 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed the required things as requested
AlfiyaSiddique
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
gssoc-ext
For GSSOC Extended Contribution.
hacktoberfest-accepted
level 1
GSSOC level 1 Contribution - 10 points
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Regarding issue #31
I have added validation for checking if the ingredients and steps are populated fore adding next steps and ingredients.
Also added nodemon instead of node as its more efficient while testing out.
Kindly add this under gssoc ext and hacktober