-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance Card Image Responsiveness on Small Screens (#327) #354
Conversation
✅ Deploy Preview for delightful-daifuku-a9f6ea ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Thank you @dipexplorer for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better.
Hi @AlfiyaSiddique , I have completed the necessary changes and requested reviews, but it appears that the pull request is blocked automaticaly. I want to ensure I follow the proper procedures and comply with the repository's rules. Could you please provide guidance on what steps I should take to move forward? or is there anything else I might need to address to get this PR approved? |
@dipexplorer one comment |
And @dipexplorer how did you approve changes in issue #310 ?? |
I approved the PR unconditionally by mistake. Sorry for the oversight—I’ll be more careful moving forward. |
Also please update the PR |
@AlfiyaSiddique , |
@dipexplorer above I have asked you to move the styles to CSS file that you have not done yet that's why! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixing css conflict
@dipexplorer please update your pr there are new changes which is not reflecting on this PR |
Like the footer |
What does this PR do?
This PR improves the responsiveness of the card image on small screens to maintain a balanced layout, fixing layout issues on mobile devices where the image covers excessive space.
Fixes #327.
How should this be tested?
Test 1: Resize browser window below 750px width and verify the card image resizes proportionately to maintain a balanced layout.
Test 2: Check that the image and other card elements adjust without causing overflow or unbalanced space on smaller screens.
Checklist