Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate Unsupported Filters #5512

Open
Nzzyme opened this issue Nov 16, 2024 · 2 comments
Open

Indicate Unsupported Filters #5512

Nzzyme opened this issue Nov 16, 2024 · 2 comments

Comments

@Nzzyme
Copy link

Nzzyme commented Nov 16, 2024

Issue Details

I added a custom IP filter by navigating to:

Settings > Filtering > Filters > Custom filters

Later, I updated all the filters from the main home screen. When I opened a web browser and tried to open one of the IP addresses listed in the filter link (For Ex: 195.158.4.210), AG did not block this in the web browser perhaps due to unsupported filter rule syntax. Checking the 'Recent activity' confirmed no block on that IP address.

Proposed solution

In this case, it would be beneficial if AG immediately notifies the user after adding a filter that the filter is unsupported (displaying "Filter not supported" text in red) and prevents the user from enabling such a filter (by graying out the toggle switch for unsupported filters). Currently, the filter can be enabled, giving the impression that everything is 'fine' with that filter, when in reality, it is not effective.

image

Alternative solution

Manually check the compatibility of filters

@maxikuzmin
Copy link
Contributor

@Nzzyme unfortunately it is not possible to open or copy the filter link. Could you please re-send the link or email [email protected] with issue number 5512?

@Nzzyme
Copy link
Author

Nzzyme commented Nov 18, 2024

@Nzzyme unfortunately it is not possible to open or copy the filter link. Could you please re-send the link or email [email protected] with issue number 5512?

Here you go:

[https://raw.githubusercontent.com/stamparm/ipsum/refs/heads/master/ipsum.txt](url)

It's not just with this one filter but basically any unsupported filter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants