Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After the TV version is installed, the UI layout is still the mobile version. #5475 #5483

Open
5 of 6 tasks
x64bugreport opened this issue Oct 15, 2024 · 7 comments
Open
5 of 6 tasks

Comments

@x64bugreport
Copy link

x64bugreport commented Oct 15, 2024

Please answer the following questions for yourself before submitting an issue

  • Filters were updated before reproducing an issue
  • I checked the knowledge base and found no answer
  • I checked to make sure that this issue has not already been filed

AdGuard version

4.6.92

Environment

OS version:Android 11
Device:Station M2

HTTPS filtering

  • yes, I do

Root access

  • yes, I have it

Integration with AdGuard VPN

  • yes, I do

Routing mode

Local VPN

Ad Blocking

No response

Privacy

No response

Social

No response

Annoyances

No response

Security

No response

Language-specific

No response

Other

No response

Which DNS server do you use?

AdGuard DNS

DNS protocol

None

Custom DNS

No response

What Stealth Mode options do you have enabled?

No response

Issue Details

Steps to reproduce:
1.download from agrd.io/tvapk
2.adb install adguard tv apk
3.After opening, the UI layout is still the mobile version.

Expected Behavior

No response

Actual Behavior

I hope that the TV version can be forced to set the TV layout without relying on the software to detect the model itself, and hope that the resolution can be adapted.

Screenshots

No response

Additional Information

First of all, I am a lifetime paying user of AdGuard. I am not happy with your perfunctory closing of my question. You closed my question on the grounds that my device is not a TV. This is ridiculous!!! You developed poor code and put the landscape device detection logic at the end. Are you proud of this? My media box is a playback device for an external TV. Doesn't it deserve a TV version?

This is an old issue. If you continue to reject my request with this ridiculous reason, I will open a new issue.
#5475

Finally, post the poor detection code you wrote.
public static final boolean b(Activity activity) {
n.g(activity, "");
Object systemService = activity.getSystemService("uimode");
n.e(systemService, "null cannot be cast to non-null type android.app.UiModeManager");
int i = activity.getResources().getConfiguration().orientation;
int currentModeType = ((UiModeManager) systemService).getCurrentModeType();
if (currentModeType != 0) {
if (currentModeType == 4) {
return true;
}
return false;
}
if (activity.getPackageManager().hasSystemFeature("android.hardware.touchscreen")) {
return false;
}
View decorView = activity.getWindow().getDecorView();
n.f(decorView, "getDecorView(...)");
if (i != 0) {
if (i == 2) {
return true;
}
} else if (decorView.getWidth() > decorView.getHeight()) {
return true;
}
return false;
}

If this issue is closed again, I will open a new issue and provide a patch to force the adguard modified version of TV UI to open. I hope that the basic needs of a lifetime paying user can be taken seriously by your team, rather than perfunctorily.

@x64bugreport
Copy link
Author

Please do not assign the issue to this unprofessional person. @ESurina

@x64bugreport
Copy link
Author

x64bugreport commented Oct 15, 2024

I hope the AdGuard team can have a positive attitude to deal with user demands, instead of continuing to perfunctorily tell me that my device is a horizontal screen player and it is not supported. This reason is ridiculous. If you don't want to write code corrections, there is no need to perfunctorily tell me.@ESurina I hope the adguard team can assign a responsible and capable developer to solve this problem. If that doesn't work, I can help you write this part of the code. Is it so difficult to be compatible with horizontal screen playback devices?

@Versty
Copy link
Contributor

Versty commented Oct 16, 2024

@x64bugreport First of all, I apologize for the inconvenience.

We have additionally discussed this matter with the development team and decided to rework the code related to device detection.

The fix will be available in future versions of AdGuard application.

@x64bugreport
Copy link
Author

@x64bugreport First of all, I apologize for the inconvenience.

We have additionally discussed this matter with the development team and decided to rework the code related to device detection.

The fix will be available in future versions of AdGuard application.

Thank you very much for your reply, I hope I can use TV UI adguard on my box in a later version.

@x64bugreport
Copy link
Author

x64bugreport commented Nov 1, 2024

The fix will be available in future versions of AdGuard application.
@Versty
When is the version that supports the horizontal screen of the TV box expected to be released?

@x64bugreport
Copy link
Author

@Versty So far, I still cannot use the adguard TV view on landscape devices. How long will it take to resolve this issue?

@x64bugreport
Copy link
Author

As you said before, the TV view detection options will be redesigned. How long will this process take?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants