Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FF 91.9.0esr - The extension can be disabled even when the password is set #60

Closed
mabequinho opened this issue May 10, 2022 · 10 comments
Closed
Labels
enhancement New feature or request help wanted Extra attention is needed relevant Important

Comments

@mabequinho
Copy link

Version
2.6.5

FF 91.9.0esr (64-bit) from Debian stable repos

@AXeL-dev
Copy link
Owner

AXeL-dev commented May 11, 2022

Hum 🤔 , Can you provide more details please? Like the websites you're trying to block? (you can send that to me on my email if it's confidential).

Also a screenshot of the issue or a video might help me to better understand. Thank you.

Edit: does version 2.6.4 work well?

@mabequinho
Copy link
Author

mabequinho commented May 11, 2022

same issue using 2.6.4, i´m using whitelist mode.

You may need to download the video to watch it properly.

distractmetest.mp4

@AXeL-dev
Copy link
Owner

AXeL-dev commented May 11, 2022

same issue using 2.6.4, i´m using whitelist mode.

You may need to download the video to watch it properly.
distractmetest.mp4

Do you have the domain name youtube.com on your whitelist? can you send me a screenshot of the whitelist settings please. I might need to know what's on your blacklist settings as well. Thank you.

@mabequinho
Copy link
Author

same issue using 2.6.4, i´m using whitelist mode.
You may need to download the video to watch it properly.
distractmetest.mp4

Do you have the domain name youtube.com on your whitelist? can you send me a screenshot of the whitelist settings please. I might need to know what's on your blacklist settings as well. Thank you.

My friend, the blocking procedures are working flawlessly, the problem is that i can disable the entire extension without password by directly entering the add-ons and configuration FF menus.
photo_2022-05-11_11-40-11

@AXeL-dev
Copy link
Owner

AXeL-dev commented May 11, 2022

My friend, the blocking procedures are working flawlessly, the problem is that i can disable the entire extension without password by directly entering the add-ons and configuration FF menus. photo_2022-05-11_11-40-11

This is a known issue, & firefox doesn't provide a way to disallow the user from disabling an extension, you should open an issue in the mozilla addons repo for that.

Additionnaly, even your password can be bypassed easily (check this #27 (comment)).

@AXeL-dev AXeL-dev added wontfix This will not be worked on and removed to investigate labels May 11, 2022
@stale stale bot removed the wontfix This will not be worked on label May 11, 2022
@AXeL-dev AXeL-dev changed the title FF 91.9.0esr not blocking config and addons menu FF 91.9.0esr - The extension can be disabled even when the password is set May 11, 2022
@mabequinho
Copy link
Author

this addon foxfilter can do it.

@AXeL-dev
Copy link
Owner

this addon foxfilter can do it.

They probably use a hacky way for that, since from what i know there is no API that let you do this.

Nonetheless, i'll try to have a look on their code source if it's open source & check how it is implemented.

@AXeL-dev AXeL-dev added help wanted Extra attention is needed relevant Important labels May 11, 2022
@mabequinho
Copy link
Author

mabequinho commented May 11, 2022

I am currently using the following policies.json file as a workaround. It prevents disable and/or uninstall.

{ "policies": { "ExtensionSettings": { "[email protected]": { "installation_mode": "force_installed", "install_url": "https://addons.mozilla.org/firefox/downloads/latest/ublock-origin/latest.xpi" }, "{5f884915-160e-4276-a216-770a753a3abe}": { "installation_mode": "force_installed", "install_url": "https://addons.mozilla.org/firefox/downloads/latest/distract-me-not/latest.xpi" }, "Extensions": { "Locked": ["{5f884915-160e-4276-a216-770a753a3abe}"] } } } }

@AXeL-dev
Copy link
Owner

I am currently using the following policies.json file as a workaround. It prevents disable and/or uninstall.

{ "policies": { "ExtensionSettings": { "[email protected]": { "installation_mode": "force_installed", "install_url": "https://addons.mozilla.org/firefox/downloads/latest/ublock-origin/latest.xpi" }, "{5f884915-160e-4276-a216-770a753a3abe}": { "installation_mode": "force_installed", "install_url": "https://addons.mozilla.org/firefox/downloads/latest/distract-me-not/latest.xpi" }, "Extensions": { "Locked": ["{5f884915-160e-4276-a216-770a753a3abe}"] }, } } }

🤔 this looks interesting, still i'm not sure if there is an API on firefox that let you update/add new policies, otherwise i think that the solution used by foxfilter isn't so hard to implement, so i'll be working on it once i have some time to.

@AXeL-dev AXeL-dev added enhancement New feature or request todo Todo task labels May 11, 2022
@AXeL-dev AXeL-dev removed the todo Todo task label May 15, 2022
@AXeL-dev
Copy link
Owner

Fixed in version 2.7.0, you still need to enable the following option in the settings:

Capture d'écran Deepin_zone de sélection _20220514193447

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed relevant Important
Projects
None yet
Development

No branches or pull requests

2 participants