Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake lacks install target #1132

Open
BwL1289 opened this issue Aug 5, 2024 · 17 comments
Open

CMake lacks install target #1132

BwL1289 opened this issue Aug 5, 2024 · 17 comments

Comments

@BwL1289
Copy link

BwL1289 commented Aug 5, 2024

Platform:
Aarch64 Linux

Problem description:
When trying to compile from source using CMake and Ninja, I see the following error:

30.90 ninja: error: unknown target 'install'

It seems CMake lacks an install target.

Have tried manually installing libs, its symlinks, and headers automatically but to no avail.

Here's an example of how AWS implemented this for their C SDK.

This is likely an extension of #1048.

@BwL1289 BwL1289 changed the title CMake lacks install target for ninja install CMake lacks install target Aug 5, 2024
@BwL1289
Copy link
Author

BwL1289 commented Aug 12, 2024

@morgolock any chance to make this a priority?

@morgolock
Copy link

Hi @BwL1289

Thanks for raising this, I'll discuss it with the team.

@BwL1289
Copy link
Author

BwL1289 commented Aug 12, 2024

Thank you.

@BwL1289
Copy link
Author

BwL1289 commented Aug 15, 2024

Hi @morgolock. Not trying to be a bother. Please let me know if the team thought this was worth prioritizing. Thank you!

@morgolock
Copy link

Hi @BwL1289

Yes we will do it, I will ask for this to be in the next release. Once I get confirmation I will let you know.

@BwL1289
Copy link
Author

BwL1289 commented Aug 17, 2024

Thanks @morgolock.

@morgolock
Copy link

Hi @BwL1289

It's likely we will start working on this in a couple of weeks.

Hope this helps.

@BwL1289
Copy link
Author

BwL1289 commented Sep 6, 2024

@morgolock yes that helps. Thank you.

@BwL1289
Copy link
Author

BwL1289 commented Sep 27, 2024

@morgolock do you have an updated timeline? Thank you.

@morgolock
Copy link

Hi @BwL1289

We are currently discussing it, once we have a good idea of the effort I will give you an update. I'll know more in the coming days.

Hope this helps

@BwL1289
Copy link
Author

BwL1289 commented Oct 8, 2024

Thanks.

@BwL1289
Copy link
Author

BwL1289 commented Oct 30, 2024

@morgolock following up again. Can you please let me know if the team plans to fix this?

@morgolock
Copy link

Hi @BwL1289

The following patch will solve the problem. This fix will be present in v24.11

Hope this helps

@morgolock morgolock added this to the v24.11 milestone Nov 4, 2024
@BwL1289
Copy link
Author

BwL1289 commented Nov 4, 2024

@morgolock thank you.

@BwL1289
Copy link
Author

BwL1289 commented Nov 25, 2024

@morgolock please reopen this issue. It looks like you guys forgot to merge the patch into 24.11: https://github.com/ARM-software/ComputeLibrary/blob/v24.11/CMakeLists.txt#L335. The patch you mentioned is not present.

@BwL1289
Copy link
Author

BwL1289 commented Nov 26, 2024

FWIW, I forked this repo and implemented the change manually. I can confirm it works. I opened a PR: #1151

@morgolock
Copy link

Hi @BwL1289

Apologies for the confusion, I've reopened the issue.

We cannot merge the PR on github unfortunately, we only publish a snapshot of the main dev repo on github and if we merge a PR it will go out of sync with the release branch in the dev repo.

Apologies for the confusion. This patch will be present in our next release 24.11.1.

@morgolock morgolock modified the milestones: v24.11, v24.11.1 Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants