Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: the discord icon redirects to discord page of aossie #403

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

ARYPROGRAMMER
Copy link

Description

This PR improves the app by adding the feature to redirect user of AOSSIE discord page, they can discuss various topic there and learn more about this open source initiative

No Issue was raised, this PR directly implements the feature after manually going through the app

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

This was tested on a real Android 14.0.1 Redmi Note 10 Pro device. Below is the video of the implementation:

test_run.mp4

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tag the PR with the appropriate labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant