-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG:Security vulnerability , .env file committed to repo #71
Comments
@Pranav0-0Aggarwal can you please help explain the need of this .env file ? |
i am working on it |
fixes AOSSIE-Org#71 what i have done: Added .env in .gitignore file this PR will make the env file get removed from repo online and in future it will not get pushed back to repo if any changes detected by git additonal note: To fully address the issue, the .env file should be removed from the Git history using tools like BFG Repo-Cleaner or git filter-branch. Additionally, any sensitive keys or credentials should be rotated to ensure they are secure.
@Dhruv-pahuja please from next time let's first enquire if the person who has raised the issue is working on it or not ...that's how open source works if. I am not wrong !. |
Let's not jump right into solving issue without consulting the issue master 😔. |
ohh so sorry @yashpandey06 , i will consider this from next time and i may close this PR if you are working on it. |
@Dhruv-pahuja please don't close the PR ...but lets be active from next time . |
@yashpandey06 , I think env file only contains default keys that are available to everyone. Also, in the Docker setup, he uses these keys as env variables. |
|
@yashpandey06 yepp, it's good practice .Although I also figured out a few bugs, they are only one or two errors. Should I create a PR for that or include it in a bigger PR? |
Is there an existing issue for this?
What happened?
.env file is being pushed to the repo, we should rather use some other means to keep these secrets private right ?
Record
The text was updated successfully, but these errors were encountered: