Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implementing frontend | restructuring data backend #9

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

keshav-nischal
Copy link

@keshav-nischal keshav-nischal commented Jan 3, 2024

Screencast.from.29-12-23.02.24.11.PM.IST.webm

issues #2 #5
the above video shows how the frontend would look like

I choose using typescript react shadcn tailwind for the frontend
I choose react because in previous version plain html/css javascript was being used. it was hard to add new features and using react solves that
Also we can easily manage the states in react when the extension gets out of focus which is issue that is mension in #6

further I changed the json data structure in which backend and frontend were talking with each other
from

{"question1":"answer1",
"question2": "answer2"}

to
{"one_word": [{"question":"question1""answer":"answer1"},{"question":"question2":"answer":"answer2"}]}
this is more structured and allows to scale the extension for more types of questions in the future

if any suggestions and improvement, please inform.

@faresh9
Copy link

faresh9 commented Jan 4, 2024

Good work dude, hope this PR gets merged soon.

@AviGawande
Copy link

hello @keshav-nischal could you please guide me how to run the project, i had already cloned the project and done with the model A and model B

@keshav-nischal
Copy link
Author

keshav-nischal commented Feb 4, 2024

You are done with model a and b and cloning the extension. Just add it in browser and run the server

@AviGawande
Copy link

@keshav-nischal It's not working could you please tell me in detail.i possible any documentation.I know it is very small project to setup but it is not happening.
Does we had to do the changes in Model A and B.

@keshav-nischal
Copy link
Author

keshav-nischal commented Feb 5, 2024

Are you talking about my pr specifically or project in general?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants