[IMPROVEMENT] EDUAID_WEBSITE-UI-Background-MissFit_Fixed #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i request the maintainers of this repo to look at my pull request |
|
@Aditya062003 have a look at this |
|
@Hamza1821 pls fix the PR. You have also pushed the virtual env |
|
Sir please mention the file |
|
Should i remove entire venv folder in backend folder ...please guide me |
|
sir now you can merge |
|
pLease review this PR @Aditya062003 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In UI of EDUAID website , All the page's backgrounds were Missfits At 100%screen zoom
below is the images of those backgrounds :
Steps to Reproduce This issue
1) Run the frontend Server by command `npm run start`2) visit any page n browser set the screen zoom level to 100% and scroll down.
What and How i Fix This Issue
Step 1 :
I created a CSS class called `scrollable_bg`assign it the property `background-attachment : fixed` and `overflow-y : scroll`
Step 2 :
I assign the class `scrollable_bg` to Parent divs of each pages and also to divs which renders the customized radiant backgroundUi after the Issue is fixed