Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Upload PDF not working #14

Open
Roaster05 opened this issue Mar 12, 2024 · 5 comments
Open

[Bug] Upload PDF not working #14

Roaster05 opened this issue Mar 12, 2024 · 5 comments

Comments

@Roaster05
Copy link
Contributor

Expected Output:

While uploading the application/pdf type of file its text content should have been rendered in the inputbox's content

How to Reproduce:

  • Open the extension Popup and click on Upload PDF button
  • Select an application/pdf type of file from your local system
  • No changes will be detected even after uploading the file

Reasons:

The popup is being displayed using the text_input.html file where the file is being uploaded using the input tag, this html file is using the script text_input.js where the implementation of accessing the pdf's text content is done using an external library pdfjsLib which isn't imported any where in the extension's repository and hence it is not able to access the text content of the pdf being uploaded, also the Content-Security-Policy doesn't allow external scripts to be imported .

Screencast.from.2024-03-12.16-00-10.webm
@IcyArse
Copy link

IcyArse commented Mar 12, 2024

Would changing the input variable to directly go into forms text_input.html and try to remove the need of external library be a helpful solution? I would like to try out this issue as someone trying to enter open source development.

@Roaster05
Copy link
Contributor Author

Would changing the input variable to directly go into forms text_input.html and try to remove the need of external library be a helpful solution? I would like to try out this issue as someone trying to enter open source development.

I have fixed that already in my recent PR #15, Thanks anyway

@Raghucharan16
Copy link

If the issue is closed, close the issue.🤓
If it is still open, I can work on it.
thanks.

@Roaster05
Copy link
Contributor Author

If the issue is closed, close the issue.🤓 If it is still open, I can work on it. thanks.

Hello @Raghucharan16 the issue has still not recieved any comments from the assigned mentors so this will be kept open till then , although a PR has already been made associated with this issue.

@Raghucharan16
Copy link

Yeah @Roaster05 saw that. Thought I would give a try to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants