Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased metric hits when static rules are same as auto-fetched ones. #73

Open
rahulanand16nov opened this issue Nov 1, 2021 · 0 comments

Comments

@rahulanand16nov
Copy link
Contributor

rahulanand16nov commented Nov 1, 2021

When mapping rules present in the static config and auto-fetched ones are the same, it leads to a combined report of these metrics, which can be confusing for the user if not explicitly stated.

For example, static rules contain pattern GET '/' with an increase of 1 for the 'hits' metric and auto-fetched also include the same then reported metric is 2 for the 'hits' metric.

Either we can check if it's duplicate and avoid adding that rule, or we can have it as it is and explicitly state the consequence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant