-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1316: support resilient redis mode for cache util #1324
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@kevprice83 I'm not sure if this affects you.
Thanks @eloycoto and @unleashed .. Tests run is passing: $ make busted-util
EXTRA_CFLAGS="-DHAVE_EVP_KDF_CTX=1" /usr/local/openresty/luajit/bin/rover install --roverfile=gateway/Roverfile > /dev/null
/usr/local/openresty/luajit/bin/rover exec bin/busted "spec/threescale_utils_spec.lua"
●●●
3 successes / 0 failures / 0 errors / 0 pending : 0.022514 seconds |
Guys I thought again about current implementation and think it's better to keep This way will make the redis connect use either based on the What do you think @unleashed @eloycoto @kevprice83 ? Update: bash-4.4$ make busted-util
EXTRA_CFLAGS="-DHAVE_EVP_KDF_CTX=1" /usr/local/openresty/luajit/bin/rover install --roverfile=gateway/Roverfile > /dev/null
/usr/local/openresty/luajit/bin/rover exec bin/busted "spec/threescale_utils_spec.lua"
●●●
3 successes / 0 failures / 0 errors / 0 pending : 0.02537 seconds |
Tests passing: ``` $ make busted-util /usr/local/openresty/luajit/bin/rover exec bin/busted "spec/threescale_utils_spec.lua" ●●● 3 successes / 0 failures / 0 errors / 0 pending : 0.02537 seconds ```
In general I think this is fine and adds a useful option. We could probably look at extending error_handler in the future to map the same auth caching modes we support in the auth caching policy: |
Unit Tests: ``` $ make busted-util EXTRA_CFLAGS="-DHAVE_EVP_KDF_CTX=1" /usr/local/openresty/luajit/bin/rover install --roverfile=gateway/Roverfile > /dev/null /usr/local/openresty/luajit/bin/rover exec bin/busted "spec/threescale_utils_spec.lua" ●●● 3 successes / 0 failures / 0 errors / 0 pending : 0.039009 seconds ```
@kevprice83 please review this PR and we decide to merge or close it |
Hi @eguzki @kevprice83, could you decide on this PR clousre? |
This resolves #1316 and make it useful to use the cache without fail in case of network disconnect, etc.
Tests passing:
(results included in commit message)