Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing aggregate.cov #214

Open
wumb0 opened this issue Sep 14, 2024 · 1 comment
Open

Missing aggregate.cov #214

wumb0 opened this issue Sep 14, 2024 · 1 comment

Comments

@wumb0
Copy link
Contributor

wumb0 commented Sep 14, 2024

Between v0.3.2 and v0.4 the fuzzing server stopped generating the aggregate.cov file. The code was in server.h.
The README still indicates that the fuzz server maintains an aggregate coverage file "coverage.cov".

Was this removed on purpose? As the README indicates, it's useful to have a single aggregate coverage file.

Of course I do realize I can just generate cov traces via the run command using the output directory as the --input argument and then concat them into a single trace file, but since it's still in the readme I wanted to inquire. I think Lighthouse has the "Code coverage batch" option too, which would do the same thing.

@0vercl0k
Copy link
Owner

Hello!

Sorry for the delay - I am mostly away from computer until November :)

Yeah I did remove it on purpose because I started to question how useful it was. Also, I seem to remember that when adding the edge coverage for bxcpu, the file became less useful has it had a bunch of values that weren't 'real' addresses. I can't remember exactly how annoying it'd be to log only valid ones.

I'd definitely be open to try to re-add this / review a PR if you think it's worth it :)

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants